unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Stafford Horne <shorne@gmail.com>
Cc: GLIBC patches <libc-alpha@sourceware.org>
Subject: Re: [PATCH] stdlib: Fix tst-makecontext2 log when swapcontext fails
Date: Fri, 22 Mar 2024 10:00:59 -0700	[thread overview]
Message-ID: <CAMe9rOqJbAtAbX6DndBaPVVro15ychMK79hdLaMWKSUHZXDOCA@mail.gmail.com> (raw)
In-Reply-To: <20240322154919.1732176-1-shorne@gmail.com>

On Fri, Mar 22, 2024 at 8:50 AM Stafford Horne <shorne@gmail.com> wrote:
>
> The log incorrectly prints, setcontext failed.  Update this to indicate
> that actually swapcontext failed.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
>  stdlib/tst-makecontext2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stdlib/tst-makecontext2.c b/stdlib/tst-makecontext2.c
> index 5091b126a0..2434cb2af3 100644
> --- a/stdlib/tst-makecontext2.c
> +++ b/stdlib/tst-makecontext2.c
> @@ -63,7 +63,7 @@ do_test (void)
>        makecontext (&ucp, (void (*) (void)) cf, 2, 78, 274);
>        if (swapcontext (&ucp2, &ucp) != 0)
>         {
> -         puts ("setcontext failed");
> +         puts ("swapcontext failed");
>           return 1;
>         }
>
> --
> 2.44.0
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.

      reply	other threads:[~2024-03-22 17:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 15:49 [PATCH] stdlib: Fix tst-makecontext2 log when swapcontext fails Stafford Horne
2024-03-22 17:00 ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOqJbAtAbX6DndBaPVVro15ychMK79hdLaMWKSUHZXDOCA@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).