From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_OTHER_BAD_TLD,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 263BA1F8C6 for ; Thu, 29 Jul 2021 14:27:25 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E7873864827 for ; Thu, 29 Jul 2021 14:27:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E7873864827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627568844; bh=I/Z/Ncd8OaBkyIgD+l/P4Qa2esyY3eq2RnFohxT37Aw=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uulBYft7E+V6AsUXxjkdgfac5bor+opboz2ShFrl6EdiXYdpZbN7r/1oPMYzwX8ey CLuxYh4Sey7MjftQKsahBSiqF0U4Zn8p1/yevkVkjTTLEJ5TC6UlHlbwhYQx5LeHHb BOjgi/cST2KDo5SsYQ9664WyUCt8QhW3n6Igv8I0= Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id D961A3864827 for ; Thu, 29 Jul 2021 14:27:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D961A3864827 Received: by mail-pl1-x62d.google.com with SMTP id t21so7138648plr.13 for ; Thu, 29 Jul 2021 07:27:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I/Z/Ncd8OaBkyIgD+l/P4Qa2esyY3eq2RnFohxT37Aw=; b=X3gOzQ7NMmMi5dpIwaaBnaZsSG7K7LUsLwK0PcwUGhoqqGe7ws96B86IahYFjo4NZt 9Oglx1C2yYiVHhXiDEEN7cKGmnyBubmalq4WY26Rle0Ql7V+xv6FpXyp+/jxabiKSeyx pAvucGiw/u/oyMGmYqPmVYdiyorkL8h+RRB7lAKLDYfR4nCXqvVfZrUh+hsRnF4Ey7MS HwHDSXgsOjmTjpZU433/+UV7J7pfEKGg6zGqUhq55wUsmGbaZoNhNjqX9BE9EULhIZ5l Zh8JZZ4EF3bixoSrlVMaQZEkfT2ta5pyMfsCgePPP5wxc34qyEi8id0aBuJbT1h0mRFB e+YA== X-Gm-Message-State: AOAM530UuhOzTgUBr/jpuyW4KTMeweKI79uHZNncqWqU3zIJ15Y+Re4D Jbm230NyVkXPg43mHBjB3WN6rCfZmzC+qYcc9oI= X-Google-Smtp-Source: ABdhPJxm1IEMnV55guKM+LZRhwcIbgO8pDQi5zf73/cCcAnYgWhgNexJVFF7Ss3ZESPx9BJI7Hl40WZ9yNsiZ+/yGCI= X-Received: by 2002:a17:90a:62cb:: with SMTP id k11mr15271606pjs.153.1627568823930; Thu, 29 Jul 2021 07:27:03 -0700 (PDT) MIME-Version: 1.0 References: <20210726035802.275992-1-maskray@google.com> <20210726035802.275992-2-maskray@google.com> In-Reply-To: <20210726035802.275992-2-maskray@google.com> Date: Thu, 29 Jul 2021 07:26:28 -0700 Message-ID: Subject: Re: [PATCH 1/3] elf: Replace .tls_common with .tbss definition To: Fangrui Song Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Sun, Jul 25, 2021 at 8:59 PM Fangrui Song via Libc-alpha wrote: > > .tls_common is obsoleted, not supported by clang -fintegrated-as or ld.lld. > Just change it to .tbss for portability. Please update the commit log for BZ #28152 > > --- > elf/tls-macros.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/elf/tls-macros.h b/elf/tls-macros.h > index e25e33b0f0..a637407417 100644 > --- a/elf/tls-macros.h > +++ b/elf/tls-macros.h > @@ -1,7 +1,11 @@ > /* Macros to support TLS testing in times of missing compiler support. */ > > #define COMMON_INT_DEF(x) \ > - asm (".tls_common " #x ",4,4") > + asm (".section .tbss\n\t" \ > + ".globl " #x "\n\t" \ > + ".balign 4\n\t" \ > + #x ":\t.space 4\n\t" \ > + ".previous") > /* XXX Until we get compiler support we don't need declarations. */ > #define COMMON_INT_DECL(x) > > -- > 2.32.0.432.gabb21c7263-goog > -- H.J.