From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "H.J. Lu" Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: [PATCH 0/2] nptl: Update struct pthread_unwind_buf Date: Thu, 8 Mar 2018 21:23:58 -0800 Message-ID: References: <20180201205757.51911-1-hjl.tools@gmail.com> <877er1b4zp.fsf@mid.deneb.enyo.de> <87371pb3ga.fsf@mid.deneb.enyo.de> <87tvu59o21.fsf@mid.deneb.enyo.de> <87po4t9mxt.fsf@mid.deneb.enyo.de> <3764b0a1-9f26-6f5f-1bc5-d374f2672f3a@redhat.com> <86d5d5ba-2b53-1904-dada-3efe2b3ad501@redhat.com> <304b73fa-bda0-f0a9-e252-e5a062d1182f@redhat.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1520572926 8650 195.159.176.226 (9 Mar 2018 05:22:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Mar 2018 05:22:06 +0000 (UTC) Cc: "Tsimbalist, Igor V" , Florian Weimer , GNU C Library To: "Carlos O'Donell" Original-X-From: libc-alpha-return-90915-glibc-alpha=m.gmane.org@sourceware.org Fri Mar 09 06:22:01 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=YsH3 tB7hJpgtzQb7m8DiwGvw2h5z21xTwnca7Ulayd+p9ZyKr7GYHVchS293+F0fX9mn KqcTntkXRbi19ERFM/KAzVavb/w1PXrBce6qjQ6BIfl+gs8abh+AUrGs5Aw5xV9l H2sxlRHjTBQ1V9DDncd1/OgbSB7x0FXCqy7DkHg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; s=default; bh=WivKpR8ASM H4Pcm24OzFAM8f4pc=; b=SMqt0iqxuaehYxkHPnFqeK0qo7Sy89ipfiibiL395U HqMZQxmvx+HgFt9AqjrehljojI2hjEe9pWPTBaciumUH8R6DcLIs2/EptTNl7QE2 /G7OLcwxYq17Su/9gFsmh1EL+XrNjnvS9U0sPGnfL04I5jNeKRsw51GN0rt3tnLs Y= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f67.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WKU1o0/txcsLGi/xgEhwiy6cktY8/H2jOPp5on7+8fU=; b=lFbESPUS5RrsZSlrW6uN3sPRllcrIXRKegsdmfi3+T0GEDjK6sX4dHs3rFAIA0cZuv pED+Ak3hZ9frlG5vf0VZzjooT848W0a32i1bVaVtjREoSk6Px4uoB5w8Nj2XgeBPPUe/ v2UHLvDZk9vBJj3goioi/tDfACMU5KVQi3pVhvpTJ2wu8c2dXcQey9vUlkj3bh3lzWiY v3860AnVyLQX6DTTddnl3nIaMgAItkuEA1XeC8BTI4PxsEvn4uWCT7dCpu0AlOYSpiZq M1RoqcO50zJO4OSo6WLifzYX6Q4/QKH/ZA8BGHimYnusnqNPcmBgi03JdgzGZ1Oe0mNS WzhQ== X-Gm-Message-State: AElRT7H95qLLyhvfJF7T/4HxBTueZHxqJUzLY9lRRaA0htqyDq7xgiuZ LWO1/GZ6xjx+OsYx2WjyUm9EgAHYoFAXwpVKuWo= X-Google-Smtp-Source: AG47ELsbPnvfU5VR1Qe3cfDSFjI5I+02jhU8EEncHHnLww/+VMgTYVkO8fiJFVspS37ck4RDmnkiFNC8iCVGJOpQ4+w= X-Received: by 10.202.195.151 with SMTP id t145mr17672532oif.311.1520573038886; Thu, 08 Mar 2018 21:23:58 -0800 (PST) In-Reply-To: <304b73fa-bda0-f0a9-e252-e5a062d1182f@redhat.com> Xref: news.gmane.org gmane.comp.lib.glibc.alpha:83258 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euATh-00029P-Er for glibc-alpha@blaine.gmane.org; Fri, 09 Mar 2018 06:22:01 +0100 Received: (qmail 11798 invoked by alias); 9 Mar 2018 05:24:04 -0000 Received: (qmail 11758 invoked by uid 89); 9 Mar 2018 05:24:02 -0000 On Thu, Mar 8, 2018 at 4:47 PM, Carlos O'Donell wrote: > On 03/08/2018 04:48 AM, H.J. Lu wrote: >> True. This is the patch I have tested: >> >> https://github.com/hjl-tools/gcc/commit/e98087865405f051e93d5f35588789ef9686db4a > > I assume NOTRACK prefix is what Intel calls 'NO_TRACK_EN' in the CET > documentation since binutils uses the 0x3E prefix for it and that matches > the Intel CET docs. Please correct me if I'm wrong. That is correct. > In which case I agree, using NOTRACK is going to prevent a useful use > of CET against writes to the cancellation jump buffer. True. > This patch looks good to me, but is not a *correctness* issue, it is > simply that we want to extend coverage to the private cancellation > setjmp/longjmp buffers. > > Is there any way we can do this with source markup instead of via > a fragile list in the compiler? > > Presumably users may want to markup their own code like this also > if they have custom implementations of functions that behave like > setjmp/longjmp? > Yes, we can use __attribute__((__returns_twice__)). I updated hjl/setjmp/cancel branch to do that. No GCC changes are needed. -- H.J.