From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 2/2] x86: Remove wcsnlen-sse4_1 from wcslen ifunc-impl-list [BZ #28064]
Date: Tue, 1 Feb 2022 11:45:43 -0800 [thread overview]
Message-ID: <CAMe9rOq-ibjAUvoD2JgF8uQKb4sW+50upjRh_RTfnfnxPN+D_A@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOo7hK5easXXEH4jfUT5Lm8g5QOEuVUbwEXTnZdL4f5eQg@mail.gmail.com>
On Thu, Jul 8, 2021 at 1:30 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Jul 8, 2021 at 1:14 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > The following commit
> >
> > commit 6f573a27b6c8b4236445810a44660612323f5a73
> > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > Date: Wed Jun 23 01:19:34 2021 -0400
> >
> > x86-64: Add wcslen optimize for sse4.1
> >
> > Added wcsnlen-sse4.1 to the wcslen ifunc implementation list and did
> > not add wcslen-sse4.1 to wcslen ifunc implementation list. This commit
> > fixes that by removing wcsnlen-sse4.1 from the wcslen ifunc
> > implementation list and adding wcslen-sse4.1 to the ifunc
> > implementation list.
> >
> > Testing:
> > test-wcslen.c, test-rsi-wcslen.c, and test-rsi-strlen.c are passing as
> > well as all other tests in wcsmbs and string.
> >
> > Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> > ---
> > Confirmed test-rsi-wcslen.c failed before this fix.
>
> Great.
>
> > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > index dbd1ebf298..39ab10613b 100644
> > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> > @@ -684,9 +684,9 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> > && CPU_FEATURE_USABLE (AVX512BW)
> > && CPU_FEATURE_USABLE (BMI2)),
> > __wcslen_evex)
> > - IFUNC_IMPL_ADD (array, i, wcsnlen,
> > + IFUNC_IMPL_ADD (array, i, wcslen,
> > CPU_FEATURE_USABLE (SSE4_1),
> > - __wcsnlen_sse4_1)
> > + __wcslen_sse4_1)
> > IFUNC_IMPL_ADD (array, i, wcslen, 1, __wcslen_sse2))
> >
> > /* Support sysdeps/x86_64/multiarch/wcsnlen.c. */
> > --
> > 2.25.1
> >
>
> LGTM. Please check in both patches.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
I am backporting this to release branches.
--
H.J.
next prev parent reply other threads:[~2022-02-01 19:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 8:13 [PATCH v1] x86: Remove wcsnlen-sse4_1 from wcslen ifunc-impl-list [BZ #28064] Noah Goldstein via Libc-alpha
2021-07-08 12:21 ` H.J. Lu via Libc-alpha
2021-07-08 13:57 ` H.J. Lu via Libc-alpha
2021-07-08 15:08 ` H.J. Lu via Libc-alpha
2021-07-08 20:15 ` Noah Goldstein via Libc-alpha
2021-07-08 20:13 ` [PATCH v2 1/2] x86-64: Test strlen and wcslen with 0 in the RSI register " Noah Goldstein via Libc-alpha
2021-07-08 20:13 ` [PATCH v2 2/2] x86: Remove wcsnlen-sse4_1 from wcslen ifunc-impl-list " Noah Goldstein via Libc-alpha
2021-07-08 20:30 ` H.J. Lu via Libc-alpha
2022-02-01 19:45 ` H.J. Lu via Libc-alpha [this message]
2022-02-01 19:52 ` [PATCH v2 1/2] x86-64: Test strlen and wcslen with 0 in the RSI register " H.J. Lu via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOq-ibjAUvoD2JgF8uQKb4sW+50upjRh_RTfnfnxPN+D_A@mail.gmail.com \
--to=libc-alpha@sourceware.org \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).