From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 2/3] x86_64: Add glibc-hwcaps support
Date: Tue, 13 Oct 2020 04:43:27 -0700 [thread overview]
Message-ID: <CAMe9rOpw3rBW9Tr2S=Y=q-F7eh_0QwuL8ecD325D+Ac=hX6yvA@mail.gmail.com> (raw)
In-Reply-To: <87pn5mv054.fsf@oldenburg2.str.redhat.com>
On Tue, Oct 13, 2020 at 4:25 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > On Tue, Oct 13, 2020 at 2:29 AM Florian Weimer <fweimer@redhat.com> wrote:
> >>
> >> * H. J. Lu via Libc-alpha:
> >>
> >> >> diff --git a/sysdeps/x86_64/dl-hwcaps-subdirs.c b/sysdeps/x86_64/dl-hwcaps-subdirs.c
> >> >> new file mode 100644
> >> >> index 0000000000..c4d8b3a02a
> >> >> --- /dev/null
> >> >> +++ b/sysdeps/x86_64/dl-hwcaps-subdirs.c
> >>
> >> >> +#include <dl-hwcaps.h>
> >> >> +#include <cpu-features.h>
> >> >>
> >> >
> >> > Please use <sys/platform/x86.h>.
> >>
> >> How does this work? There is no wrapper header for it, so its
> >> functionality is not really available within ld.so.
> >
> > You are right.
>
> So this part is okay?
Yes.
> >> >> diff --git a/sysdeps/x86_64/tst-glibc-hwcaps.c b/sysdeps/x86_64/tst-glibc-hwcaps.c
> >> >> new file mode 100644
> >> >> index 0000000000..b46e7cb236
> >> >> --- /dev/null
> >> >> +++ b/sysdeps/x86_64/tst-glibc-hwcaps.c
> >>
> >> >> +#include <stdio.h>
> >> >> +#include <support/check.h>
> >> >> +#include <sys/param.h>
> >> >
> >> > Please include <sys/platform/x86.h>.
> >>
> >> I don't want to test the implementation against itself. I'd rather use
> >> the GCC functionality and if necessary, add the additional feature
> >> checks by open-coding the CPU analysis.
> >
> > You need to check all ISAs included in each ISA level.
> > There are testcases to check that <sys/platform/x86.h>
> > is correct.
>
> Do you still want me to use <sys/platform/x86.h> then?
>
Yes.
--
H.J.
next prev parent reply other threads:[~2020-10-13 11:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 15:21 [PATCH v2 0/3] glibc-hwcaps support for LD_LIBRARY_PATH Florian Weimer via Libc-alpha
2020-10-12 15:21 ` [PATCH 1/3] elf: Add " Florian Weimer via Libc-alpha
2020-10-13 16:28 ` Paul A. Clarke via Libc-alpha
2020-10-14 13:58 ` Florian Weimer via Libc-alpha
2020-10-14 15:14 ` Paul A. Clarke via Libc-alpha
2020-10-14 15:19 ` Florian Weimer via Libc-alpha
2020-10-20 17:23 ` Paul A. Clarke via Libc-alpha
2020-10-12 15:21 ` [PATCH v2 2/3] x86_64: Add glibc-hwcaps support Florian Weimer via Libc-alpha
2020-10-12 18:11 ` H.J. Lu via Libc-alpha
2020-10-13 9:29 ` Florian Weimer via Libc-alpha
2020-10-13 11:02 ` H.J. Lu via Libc-alpha
2020-10-13 11:24 ` Florian Weimer via Libc-alpha
2020-10-13 11:43 ` H.J. Lu via Libc-alpha [this message]
2020-10-12 15:22 ` [PATCH v2 3/3] powerpc64le: " Florian Weimer via Libc-alpha
2020-10-13 16:36 ` Paul A. Clarke via Libc-alpha
2020-10-20 17:23 ` Paul A. Clarke via Libc-alpha
2020-10-29 16:26 ` Florian Weimer via Libc-alpha
2020-10-30 23:10 ` Tulio Magno Quites Machado Filho via Libc-alpha
2020-11-02 10:15 ` Florian Weimer via Libc-alpha
2020-11-03 15:14 ` Tulio Magno Quites Machado Filho via Libc-alpha
2020-11-03 16:29 ` Florian Weimer via Libc-alpha
2020-11-03 23:02 ` Segher Boessenkool
2020-11-04 8:28 ` Florian Weimer via Libc-alpha
2020-11-04 19:36 ` Segher Boessenkool
2020-11-04 19:56 ` Florian Weimer via Libc-alpha
2020-11-04 21:58 ` Segher Boessenkool
2020-11-05 11:40 ` Florian Weimer via Libc-alpha
2020-11-05 21:42 ` Segher Boessenkool
2020-11-09 18:32 ` Florian Weimer via Libc-alpha
2020-11-16 14:51 ` Tulio Magno Quites Machado Filho via Libc-alpha
2020-11-16 19:35 ` Segher Boessenkool
2020-11-23 10:20 ` Florian Weimer via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpw3rBW9Tr2S=Y=q-F7eh_0QwuL8ecD325D+Ac=hX6yvA@mail.gmail.com' \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).