From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0E1091F8C6 for ; Tue, 24 Aug 2021 14:00:56 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24712385842A for ; Tue, 24 Aug 2021 14:00:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24712385842A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629813655; bh=l7ytowRbkl9a9NXDXv/GcHdmVkPxcUHFHuVTAuQk4v4=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=KgyXz3enlMCvMBTS+IldqhoukS+k6+Norqm92x2peGBMlHLeQDaEBCduXsUH4Sk83 esjVZOkKJNqMRzKUMVf+UV5t+mMCj9J+JbM0CPL5QKuQhE2EY0sUR9jmAeGdPOnOyU HTZVvFl2TXYQw56XTrX15dJEE8+3fXRWdG7pxWnI= Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 273AF3858405 for ; Tue, 24 Aug 2021 14:00:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 273AF3858405 Received: by mail-pf1-x434.google.com with SMTP id w68so18454953pfd.0 for ; Tue, 24 Aug 2021 07:00:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=l7ytowRbkl9a9NXDXv/GcHdmVkPxcUHFHuVTAuQk4v4=; b=ojWCO8zsRkyOXhUgLCBLgn9J9nF97rcAYpQfFZonmGeqcoMLXqXyTidJ8PlYX1HRJL FxLhFctzWUL/VP8+ObFiSzaP4Bm+UNQ7FZ2fwFOAQ7V5WDgLEamU2MG0hMtyoMkvVYW9 qprdhUetP4iCCLj1R21Ew6UZGmgZ0AhlDkGWCzcTIBlLXJQmE/6mdCBPyqZ1ov8YpSq6 eeHURlm8ihfxSdTA8DB64E2kQBJduziNS6L/SNkZoDAcGO6DvPCPaYJHp0/I5IC2Zsad 82GSvhj9PdBMQxEnTjIASaAgt8RN1+sEvrcp8oQCW8ovT5mpdgO2X1Q3aMhG0oDrIGyS TKZQ== X-Gm-Message-State: AOAM5329wfBc8np980fjAxi+O7TDE+S+VRg6UekfX5M0He2f7ghlqZ7p P3x0x+eu9uu9pb3STzc68ftNEerE0UJ0g8f5ix0B7BAp X-Google-Smtp-Source: ABdhPJxq8GSkpTdTr3qXLcnXDUTB0AxcdJtBTDSgdKKFIXxh+TRFdZPf82YSD3ga5Q96FGoLFKdk2Mu/h8rgLYhtXbk= X-Received: by 2002:a63:4d24:: with SMTP id a36mr23918071pgb.37.1629813626127; Tue, 24 Aug 2021 07:00:26 -0700 (PDT) MIME-Version: 1.0 References: <20210820135145.49237-1-hjl.tools@gmail.com> In-Reply-To: <20210820135145.49237-1-hjl.tools@gmail.com> Date: Tue, 24 Aug 2021 06:59:50 -0700 Message-ID: Subject: Re: [PATCH] x86-64: Remove compiler -mavx512f check To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Fri, Aug 20, 2021 at 6:51 AM H.J. Lu wrote: > > The minimum GCC requirement is GCC 6.2 which supports -mavx512f. Remove > compiler -mavx512f check. Tested with GCC 6.4.1 on Linux/x86-64. > --- > config.h.in | 3 --- > sysdeps/x86_64/Makefile | 2 -- > sysdeps/x86_64/configure | 26 -------------------------- > sysdeps/x86_64/configure.ac | 9 --------- > sysdeps/x86_64/fpu/Makefile | 2 -- > 5 files changed, 42 deletions(-) > > diff --git a/config.h.in b/config.h.in > index 0d92504f65..3752f9a6f7 100644 > --- a/config.h.in > +++ b/config.h.in > @@ -62,9 +62,6 @@ > /* Define if _rtld_local structure should be forced into .sdata section. */ > #undef HAVE_SDATA_SECTION > > -/* Define if compiler supports AVX512. */ > -#undef HAVE_AVX512_SUPPORT > - > /* Define if assembler supports AVX512DQ. */ > #undef HAVE_AVX512DQ_ASM_SUPPORT > > diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile > index 22c5b63ab5..7a4b576356 100644 > --- a/sysdeps/x86_64/Makefile > +++ b/sysdeps/x86_64/Makefile > @@ -134,14 +134,12 @@ CFLAGS-tst-auditmod6c.c += $(AVX-CFLAGS) > CFLAGS-tst-auditmod7b.c += $(AVX-CFLAGS) > CFLAGS-tst-avx-aux.c += $(AVX-CFLAGS) > CFLAGS-tst-avxmod.c += $(AVX-CFLAGS) > -ifeq (yes,$(config-cflags-avx512)) > AVX512-CFLAGS = -mavx512f > CFLAGS-tst-audit10-aux.c += $(AVX512-CFLAGS) > CFLAGS-tst-auditmod10a.c += $(AVX512-CFLAGS) > CFLAGS-tst-auditmod10b.c += $(AVX512-CFLAGS) > CFLAGS-tst-avx512-aux.c += $(AVX512-CFLAGS) > CFLAGS-tst-avx512mod.c += $(AVX512-CFLAGS) > -endif > > $(objpfx)tst-glibc-hwcaps: $(objpfx)libmarkermod2-1.so \ > $(objpfx)libmarkermod3-1.so $(objpfx)libmarkermod4-1.so > diff --git a/sysdeps/x86_64/configure b/sysdeps/x86_64/configure > index 75c96d60d4..d81accdc07 100755 > --- a/sysdeps/x86_64/configure > +++ b/sysdeps/x86_64/configure > @@ -28,32 +28,6 @@ if test $libc_cv_asm_avx512dq = yes; then > > fi > > -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for AVX512 support" >&5 > -$as_echo_n "checking for AVX512 support... " >&6; } > -if ${libc_cv_cc_avx512+:} false; then : > - $as_echo_n "(cached) " >&6 > -else > - if { ac_try='${CC-cc} -mavx512f -xc /dev/null -S -o /dev/null' > - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 > - (eval $ac_try) 2>&5 > - ac_status=$? > - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 > - test $ac_status = 0; }; }; then : > - libc_cv_cc_avx512=$libc_cv_asm_avx512dq > -else > - libc_cv_cc_avx512=no > -fi > - > -fi > -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_cc_avx512" >&5 > -$as_echo "$libc_cv_cc_avx512" >&6; } > -if test $libc_cv_cc_avx512 = yes; then > - $as_echo "#define HAVE_AVX512_SUPPORT 1" >>confdefs.h > - > -fi > -config_vars="$config_vars > -config-cflags-avx512 = $libc_cv_cc_avx512" > - > { $as_echo "$as_me:${as_lineno-$LINENO}: checking -mprefer-vector-width=128" >&5 > $as_echo_n "checking -mprefer-vector-width=128... " >&6; } > if ${libc_cv_cc_mprefer_vector_width+:} false; then : > diff --git a/sysdeps/x86_64/configure.ac b/sysdeps/x86_64/configure.ac > index 66219e7ce5..41baed6999 100644 > --- a/sysdeps/x86_64/configure.ac > +++ b/sysdeps/x86_64/configure.ac > @@ -16,15 +16,6 @@ if test $libc_cv_asm_avx512dq = yes; then > AC_DEFINE(HAVE_AVX512DQ_ASM_SUPPORT) > fi > > -dnl Check if -mavx512f works. > -AC_CACHE_CHECK(for AVX512 support, libc_cv_cc_avx512, [dnl > -LIBC_TRY_CC_OPTION([-mavx512f], [libc_cv_cc_avx512=$libc_cv_asm_avx512dq], [libc_cv_cc_avx512=no]) > -]) > -if test $libc_cv_cc_avx512 = yes; then > - AC_DEFINE(HAVE_AVX512_SUPPORT) > -fi > -LIBC_CONFIG_VAR([config-cflags-avx512], [$libc_cv_cc_avx512]) > - > dnl Check if -mprefer-vector-width=128 works. > AC_CACHE_CHECK(-mprefer-vector-width=128, libc_cv_cc_mprefer_vector_width, [dnl > LIBC_TRY_CC_OPTION([-mprefer-vector-width=128], > diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile > index 9a4bdd075c..1b4406380d 100644 > --- a/sysdeps/x86_64/fpu/Makefile > +++ b/sysdeps/x86_64/fpu/Makefile > @@ -68,7 +68,6 @@ $(objpfx)test-float-libmvec-sincosf-avx2: \ > $(objpfx)test-float-libmvec-sincosf-avx2.o \ > $(objpfx)test-float-libmvec-sincosf-avx2-main.o $(libmvec) > > -ifeq (yes,$(config-cflags-avx512)) > libmvec-tests += double-vlen8 float-vlen16 > tests += test-double-libmvec-sincos-avx512 \ > test-float-libmvec-sincosf-avx512 > @@ -84,7 +83,6 @@ $(objpfx)test-double-libmvec-sincos-avx512: \ > $(objpfx)test-float-libmvec-sincosf-avx512: \ > $(objpfx)test-float-libmvec-sincosf-avx512.o \ > $(objpfx)test-float-libmvec-sincosf-avx512-main.o $(libmvec) > -endif > > double-vlen2-funcs = cos exp log pow sin sincos > double-vlen4-funcs = cos exp log pow sin sincos > -- > 2.31.1 > I am checking in this patch. -- H.J.