From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A1C9E1F55B for ; Thu, 28 May 2020 14:51:21 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D0366388A837; Thu, 28 May 2020 14:51:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0366388A837 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590677480; bh=luVr/szyDVzceKZOwlBfsnFnJovYeSwjd6/bfbCMZYU=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Yqm0lC4WUWJyWYrrqvXbATwLEHxkTTuIayMgNciftCWjjf3Ltc+3VfDCSJXknlIBX esI12ElajJLKnPR8Af7FDCzbkjrc7dkHVRbIg+kLuQuT7TWP8N6UoBGSWiWPUpjT6w iazfMwWQZxneu7lfj6h89Njjje6Kyqqr0byjoWbU= Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by sourceware.org (Postfix) with ESMTPS id 7F4FB38708D0 for ; Thu, 28 May 2020 14:51:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7F4FB38708D0 Received: by mail-io1-xd44.google.com with SMTP id j8so30204289iog.13 for ; Thu, 28 May 2020 07:51:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=luVr/szyDVzceKZOwlBfsnFnJovYeSwjd6/bfbCMZYU=; b=IF6CoXyxCf+9Ohi7O6VTT09e0IlptmLygmHeM5PQM0DCP33zb9c3IdXy9/yMKpRIEv L5iXlLFxEpSEmIsuy0v4PkdxMgixTZj1MSgGeV8fgUjgMkNUstxLzr76JEZZFV44lETq vAY/8yzpLqu4SYMfxguJhbK+iLWsJ7jZ3ZHcC6sVSzGaFzSPrGXUEnmRrWrUjtIVmGkv r3hmQKP+WZf/B/nSc42WAahIBe86aE/qb8klMiAACNSt0dnIAOVFeo+5H9yAAtrbPFhc geH2v/vB1IMkDzcEYa3Ev8Jr+bjcXHfdpaPFYiW874hxZMJsh7W9zo2YTNE1MQSi/qVY aB6g== X-Gm-Message-State: AOAM5301M2RZ5ctWG6u1bx/GR3Mwlohm4LSfh75HfT7XAx5TSnLS18k9 W1nEtOO3L9S5uz8uTgMPg4yAzTEVng6xrcjJDwzz1w== X-Google-Smtp-Source: ABdhPJzBm+zn3yI8YoPtFWiUn6bkLc7SwnPisZvJpcnxznPCNSZ3lo5NITPUe7X6yySvZxBQYJMLNXdU/ribgxNIoSc= X-Received: by 2002:a6b:39c3:: with SMTP id g186mr2534418ioa.91.1590677477994; Thu, 28 May 2020 07:51:17 -0700 (PDT) MIME-Version: 1.0 References: <20200505181605.22346-1-lukma@denx.de> <87v9kkmgcw.fsf@igel.home> <87367lk0nk.fsf@oldenburg2.str.redhat.com> <87y2pdiltl.fsf@oldenburg2.str.redhat.com> <87sgfkb4ij.fsf@oldenburg2.str.redhat.com> <87sgfk9lqw.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87sgfk9lqw.fsf@oldenburg2.str.redhat.com> Date: Thu, 28 May 2020 07:50:42 -0700 Message-ID: Subject: [PATCH] Update HP_TIMING_NOW for _ISOMAC in sysdeps/generic/hp-timing.h To: Florian Weimer Content-Type: multipart/mixed; boundary="000000000000075d3805a6b6769e" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: Andreas Schwab , Alistair Francis , "H.J. Lu via Libc-alpha" , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --000000000000075d3805a6b6769e Content-Type: text/plain; charset="UTF-8" On Thu, May 28, 2020 at 7:29 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Thu, May 28, 2020 at 5:58 AM Florian Weimer wrote: > >> > >> * H. J. Lu via Libc-alpha: > >> > >> > diff --git a/sysdeps/generic/hp-timing.h b/sysdeps/generic/hp-timing.h > >> > index af9d92f7f7..99b12995f1 100644 > >> > --- a/sysdeps/generic/hp-timing.h > >> > +++ b/sysdeps/generic/hp-timing.h > >> > @@ -24,6 +24,11 @@ > >> > #include > >> > #include > >> > > >> > +#ifdef _ISOMAC > >> > +# define __timespec64 timespec > >> > +# define __clock_gettime64 clock_gettime > >> > +#endif > >> > + > >> > /* It should not be used for ld.so. */ > >> > #define HP_TIMING_INLINE (0) > >> > >> To be honest, I would have expected different definitions of the timing > >> macros. This redirection looks a bit iffy for me for _ISOMAC. > > > > What do you have in mind? > > Something like this: > > /* The clock_gettime (CLOCK_MONOTONIC) has unspecified starting time, > nano-second accuracy, and for some architectues is implemented as > vDSO symbol. */ > #ifdef _ISOMAC > # define HP_TIMING_NOW(var) \ > ({ \ > struct timespec tv; \ > clock_gettime (CLOCK_MONOTONIC, &tv); \ > (var) = (tv.tv_nsec + UINT64_C(1000000000) * tv.tv_sec); \ > }) > #else > # define HP_TIMING_NOW(var) \ > ({ \ > struct __timespec64 tv; \ > __clock_gettime64 (CLOCK_MONOTONIC, &tv); \ > (var) = (tv.tv_nsec + UINT64_C(1000000000) * tv.tv_sec); \ > }) > #endif > > in sysdeps/generic/hp-timing.h. > Here is the updated patch. OK for master? Thanks. -- H.J. --000000000000075d3805a6b6769e Content-Type: text/x-patch; charset="UTF-8"; name="0001-Update-HP_TIMING_NOW-for-_ISOMAC-in-sysdeps-generic-.patch" Content-Disposition: attachment; filename="0001-Update-HP_TIMING_NOW-for-_ISOMAC-in-sysdeps-generic-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kaqw7y1n0 RnJvbSBmMzEyYzUyZmE4MDgyOGVjZGM0NzM1OTRlMTYwZWYyZjVkMmEwMGQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFNhdCwgMjMgTWF5IDIwMjAgMTA6MDQ6MjAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBVcGRhdGUg SFBfVElNSU5HX05PVyBmb3IgX0lTT01BQyBpbgogc3lzZGVwcy9nZW5lcmljL2hwLXRpbWluZy5o Ck1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYt OApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0Cgpjb21taXQgZTk2OTgxNzViMGI2MDQw N2RiMWU4OWJjZjI5NDM3YWIyMjRiY2EwYgpBdXRob3I6IEx1a2FzeiBNYWpld3NraSA8bHVrbWFA ZGVueC5kZT4KRGF0ZTogICBNb24gTWFyIDE2IDA4OjMxOjQxIDIwMjAgKzAxMDAKCiAgICB5MjAz ODogUmVwbGFjZSBfX2Nsb2NrX2dldHRpbWUgd2l0aCBfX2Nsb2NrX2dldHRpbWU2NAoKYnJlYWtz IGJlbmNodGVzdHMgd2l0aCBzeXNkZXBzL2dlbmVyaWMvaHAtdGltaW5nLmg6CgpJbiBmaWxlIGlu Y2x1ZGVkIGZyb20gLi9iZW5jaC10aW1pbmcuaDoyMywKICAgICAgICAgICAgICAgICBmcm9tIC4v YmVuY2gtc2tlbGV0b24uYzoyNSwKICAgICAgICAgICAgICAgICBmcm9tCi9leHBvcnQvYnVpbGQv Z251L3Rvb2xzLWJ1aWxkL2dsaWJjLWdpdGxhYi9idWlsZC14ODZfNjQtbGludXgvYmVuY2h0ZXN0 cy9iZW5jaC1yaW50LmM6NDU6Ci4vYmVuY2gtc2tlbGV0b24uYzogSW4gZnVuY3Rpb24g4oCYbWFp buKAmToKLi4vc3lzZGVwcy9nZW5lcmljL2hwLXRpbWluZy5oOjM3OjIzOiBlcnJvcjogc3RvcmFn ZSBzaXplIG9mIOKAmHR24oCZIGlzbuKAmXQga25vd24KICAgMzcgfCAgIHN0cnVjdCBfX3RpbWVz cGVjNjQgdHY7ICAgICAgXAogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICBefgoKRGVmaW5l IEhQX1RJTUlOR19OT1cgd2l0aCBjbG9ja19nZXR0aW1lIGluIHN5c2RlcHMvZ2VuZXJpYy9ocC10 aW1pbmcuaAppZiBfSVNPTUFDIGlzIGRlZmluZWQuICBEb24ndCBkZWZpbmUgX19jbG9ja19nZXR0 aW1lIGluIGJlbmNoLXRpbWluZy5oCnNpbmNlIGl0IGlzIG5vIGxvbmdlciBuZWVkZWQuCi0tLQog YmVuY2h0ZXN0cy9iZW5jaC10aW1pbmcuaCAgIHwgIDEgLQogc3lzZGVwcy9nZW5lcmljL2hwLXRp bWluZy5oIHwgMTEgKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9iZW5jaHRlc3RzL2JlbmNoLXRpbWluZy5o IGIvYmVuY2h0ZXN0cy9iZW5jaC10aW1pbmcuaAppbmRleCBhMGQ2ZjgyNDY1Li5kMDE3NmZiNzZl IDEwMDY0NAotLS0gYS9iZW5jaHRlc3RzL2JlbmNoLXRpbWluZy5oCisrKyBiL2JlbmNodGVzdHMv YmVuY2gtdGltaW5nLmgKQEAgLTE4LDcgKzE4LDYgQEAKIAogI3VuZGVmIGF0dHJpYnV0ZV9oaWRk ZW4KICNkZWZpbmUgYXR0cmlidXRlX2hpZGRlbgotI2RlZmluZSBfX2Nsb2NrX2dldHRpbWUgX19j bG9ja19nZXR0aW1lNjQKICNpbmNsdWRlIDxocC10aW1pbmcuaD4KICNpbmNsdWRlIDxzdGRpbnQu aD4KIApkaWZmIC0tZ2l0IGEvc3lzZGVwcy9nZW5lcmljL2hwLXRpbWluZy5oIGIvc3lzZGVwcy9n ZW5lcmljL2hwLXRpbWluZy5oCmluZGV4IGFmOWQ5MmY3ZjcuLjE5NjBhNzFjNjIgMTAwNjQ0Ci0t LSBhL3N5c2RlcHMvZ2VuZXJpYy9ocC10aW1pbmcuaAorKysgYi9zeXNkZXBzL2dlbmVyaWMvaHAt dGltaW5nLmgKQEAgLTMyLDExICszMiwyMCBAQCB0eXBlZGVmIHVpbnQ2NF90IGhwX3RpbWluZ190 OwogLyogVGhlIGNsb2NrX2dldHRpbWUgKENMT0NLX01PTk9UT05JQykgaGFzIHVuc3BlY2lmaWVk IHN0YXJ0aW5nIHRpbWUsCiAgICBuYW5vLXNlY29uZCBhY2N1cmFjeSwgYW5kIGZvciBzb21lIGFy Y2hpdGVjdHVlcyBpcyBpbXBsZW1lbnRlZCBhcwogICAgdkRTTyBzeW1ib2wuICAqLwotI2RlZmlu ZSBIUF9USU1JTkdfTk9XKHZhcikgXAorI2lmZGVmIF9JU09NQUMKKyMgZGVmaW5lIEhQX1RJTUlO R19OT1codmFyKSBcCisoewkJCQkJCQkJXAorICBzdHJ1Y3QgdGltZXNwZWMgdHY7CQkJCQkJXAor ICBjbG9ja19nZXR0aW1lIChDTE9DS19NT05PVE9OSUMsICZ0dik7CQkJCVwKKyAgKHZhcikgPSAo dHYudHZfbnNlYyArIFVJTlQ2NF9DKDEwMDAwMDAwMDApICogdHYudHZfc2VjKTsJXAorfSkKKyNl bHNlCisjIGRlZmluZSBIUF9USU1JTkdfTk9XKHZhcikgXAogKHsJCQkJCQkJCVwKICAgc3RydWN0 IF9fdGltZXNwZWM2NCB0djsJCQkJCQlcCiAgIF9fY2xvY2tfZ2V0dGltZTY0IChDTE9DS19NT05P VE9OSUMsICZ0dik7CQkJXAogICAodmFyKSA9ICh0di50dl9uc2VjICsgVUlOVDY0X0MoMTAwMDAw MDAwMCkgKiB0di50dl9zZWMpOwlcCiB9KQorI2VuZGlmCiAKICNlbmRpZgkvKiBocC10aW1pbmcu aCAqLwotLSAKMi4yNi4yCgo= --000000000000075d3805a6b6769e--