From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: libc-alpha@sourceware.org, andrey.kolesov@intel.com,
carlos@systemhalted.org
Subject: Re: [PATCH v1] x86/fpu: Fix misspelled evex512 section in variety of svml files
Date: Fri, 18 Nov 2022 12:46:07 -0800 [thread overview]
Message-ID: <CAMe9rOpAfc=MChG616P78AbQ5DDyA92Y_uWm82Dx-sYu=uyszw@mail.gmail.com> (raw)
In-Reply-To: <20221118200036.1035947-1-goldstein.w.n@gmail.com>
On Fri, Nov 18, 2022 at 12:00 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> ```
> .section .text.evex512, "ax", @progbits
> ```
>
> With misspelled as:
>
> ```
> .section .text.exex512, "ax", @progbits
> ```
> ---
> sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_acoshf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_asinf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_asinhf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_atan2f16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_atanf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_atanhf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_cbrtf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_coshf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_erfcf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_erff16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_exp10f16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_exp2f16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_expm1f16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_hypotf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_log10f16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_log1pf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_log2f16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_sinhf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_tanf16_core_avx512.S | 2 +-
> sysdeps/x86_64/fpu/multiarch/svml_s_tanhf16_core_avx512.S | 2 +-
> 21 files changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S
> index fd84977e95..30a906ebfb 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_acosf16_core_avx512.S
> @@ -46,7 +46,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_acosf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_acoshf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_acoshf16_core_avx512.S
> index 65026e647d..7e0e314a79 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_acoshf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_acoshf16_core_avx512.S
> @@ -57,7 +57,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_acoshf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_asinf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_asinf16_core_avx512.S
> index 2accef703e..b19c8f58b6 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_asinf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_asinf16_core_avx512.S
> @@ -44,7 +44,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_asinf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_asinhf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_asinhf16_core_avx512.S
> index a0c27922e4..d77574ff8f 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_asinhf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_asinhf16_core_avx512.S
> @@ -56,7 +56,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_asinhf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_atan2f16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_atan2f16_core_avx512.S
> index 15ffa4b6c9..e6d10b0834 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_atan2f16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_atan2f16_core_avx512.S
> @@ -50,7 +50,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16vv_atan2f_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_atanf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_atanf16_core_avx512.S
> index 62d96d13ea..88b44a989c 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_atanf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_atanf16_core_avx512.S
> @@ -45,7 +45,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_atanf_skx)
> vandps __svml_satan_data_internal_avx512(%rip), %zmm0, %zmm7
> vmovups MaxThreshold+__svml_satan_data_internal_avx512(%rip), %zmm3
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_atanhf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_atanhf16_core_avx512.S
> index 94186a14cb..07094cc82f 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_atanhf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_atanhf16_core_avx512.S
> @@ -61,7 +61,7 @@
>
> #define ATANHF_DATA(x) ((x)+__svml_satanh_data_internal_avx512_al64)
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_atanhf_skx)
> vandps AbsMask+__svml_satanh_data_internal_avx512(%rip){1to16}, %zmm0, %zmm6
> vmovups ATANHF_DATA(One)(%rip), %zmm4
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_cbrtf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_cbrtf16_core_avx512.S
> index ce10cf177b..0cc7d3cf00 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_cbrtf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_cbrtf16_core_avx512.S
> @@ -46,7 +46,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_cbrtf_skx)
> vgetmantps $0, {sae}, %zmm0, %zmm8
>
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_coshf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_coshf16_core_avx512.S
> index d1a5ddf5b4..e6fcd88c4f 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_coshf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_coshf16_core_avx512.S
> @@ -54,7 +54,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_coshf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_erfcf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_erfcf16_core_avx512.S
> index 5fb5b2f0f7..f57eb22b30 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_erfcf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_erfcf16_core_avx512.S
> @@ -49,7 +49,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_erfcf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_erff16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_erff16_core_avx512.S
> index 3bdc906ec8..db51da8f28 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_erff16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_erff16_core_avx512.S
> @@ -56,7 +56,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_erff_skx)
> vmovaps %zmm0, %zmm8
> vmulps {rn-sae}, %zmm8, %zmm8, %zmm11
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_exp10f16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_exp10f16_core_avx512.S
> index 10f0b2cb37..51f0e6c693 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_exp10f16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_exp10f16_core_avx512.S
> @@ -44,7 +44,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_exp10f_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_exp2f16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_exp2f16_core_avx512.S
> index 8a5f1e3985..b94909313b 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_exp2f16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_exp2f16_core_avx512.S
> @@ -62,7 +62,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_exp2f_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_expm1f16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_expm1f16_core_avx512.S
> index 7fe830daa4..0f15a099f6 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_expm1f16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_expm1f16_core_avx512.S
> @@ -46,7 +46,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_expm1f_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_hypotf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_hypotf16_core_avx512.S
> index c92e3ab065..1d5a91cbe8 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_hypotf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_hypotf16_core_avx512.S
> @@ -80,7 +80,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16vv_hypotf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_log10f16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_log10f16_core_avx512.S
> index 0eb9b23c4e..bea2124519 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_log10f16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_log10f16_core_avx512.S
> @@ -38,7 +38,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_log10f_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_log1pf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_log1pf16_core_avx512.S
> index 2c864f0c0e..4940e93096 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_log1pf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_log1pf16_core_avx512.S
> @@ -48,7 +48,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_log1pf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_log2f16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_log2f16_core_avx512.S
> index 02b255dde8..3ada6ed349 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_log2f16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_log2f16_core_avx512.S
> @@ -37,7 +37,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_log2f_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_sinhf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_sinhf16_core_avx512.S
> index 89be733eb2..d992fc785a 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_sinhf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_sinhf16_core_avx512.S
> @@ -50,7 +50,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_sinhf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_tanf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_tanf16_core_avx512.S
> index 4e18cdc0ce..da3477f16e 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_tanf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_tanf16_core_avx512.S
> @@ -53,7 +53,7 @@
>
> #include <sysdep.h>
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_tanf_skx)
> pushq %rbp
> cfi_def_cfa_offset(16)
> diff --git a/sysdeps/x86_64/fpu/multiarch/svml_s_tanhf16_core_avx512.S b/sysdeps/x86_64/fpu/multiarch/svml_s_tanhf16_core_avx512.S
> index 84f73fdaf9..d74fc7731d 100644
> --- a/sysdeps/x86_64/fpu/multiarch/svml_s_tanhf16_core_avx512.S
> +++ b/sysdeps/x86_64/fpu/multiarch/svml_s_tanhf16_core_avx512.S
> @@ -107,7 +107,7 @@
> #define TANHF_DATA(x) ((x)+__svml_stanh_data_internal_al64)
> #define TANHF_DATA_UNALIGNED(x) ((x)+__svml_stanh_data_internal)
>
> - .section .text.exex512, "ax", @progbits
> + .section .text.evex512, "ax", @progbits
> ENTRY(_ZGVeN16v_tanhf_skx)
> /* Here huge arguments, INF and NaNs are filtered out to callout. */
> vpandd TANHF_DATA_UNALIGNED(_iExpMantMask_UISA)(%rip){1to16}, %zmm0, %zmm1
> --
> 2.34.1
>
LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2022-11-18 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 20:00 [PATCH v1] x86/fpu: Fix misspelled evex512 section in variety of svml files Noah Goldstein via Libc-alpha
2022-11-18 20:46 ` H.J. Lu via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpAfc=MChG616P78AbQ5DDyA92Y_uWm82Dx-sYu=uyszw@mail.gmail.com' \
--to=libc-alpha@sourceware.org \
--cc=andrey.kolesov@intel.com \
--cc=carlos@systemhalted.org \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).