From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 47D191F8C6 for ; Tue, 31 Aug 2021 13:27:07 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CE073858437 for ; Tue, 31 Aug 2021 13:27:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CE073858437 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630416426; bh=10RSilQiHibf58hJMrkDNWsVeniS2bJAdF1Km/yGjbE=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OR1gIwfGoKFuJ7YMI11HDG4Ql95qEPxc+pCahB0aYlRf7asccp4df6ud7YQoicClv i6lttLDS7GlghxaE1vc9rZ/S4VvFfEBeeMxTxPd9V0l7wacgzYwoTti91L6ZGheXt3 K7IyXG/lJf7TF3PRqkzqywrdCw3CO66jhGU6TxGY= Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 4A04D385843F for ; Tue, 31 Aug 2021 13:26:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A04D385843F Received: by mail-pf1-x434.google.com with SMTP id v123so14928677pfb.11 for ; Tue, 31 Aug 2021 06:26:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=10RSilQiHibf58hJMrkDNWsVeniS2bJAdF1Km/yGjbE=; b=S1WJMcttD1LS53iOeyG3NKygv5YW9M6C/jX3WwYmEi4uJTjdEhXgxXeCOgNedEdJ2w 1Qk+iNRQhwRZWab77sY/NBMUSlCe5aaOLX1peXE3jToBEOdkE5ZzKwiEpA55bQm2DJYc lPkQhscKtV0FlZ0wC6ykHAWCqJQ7uir4uwqyGiyf95aHCg4rSUhd/LfHh8yJFmLkuXjJ lC4Y1HrBTU/kBtSxpKtmy7C7BXlbHIdIh9xU0TlkpTDEVN5x2aj7QVNnMc7TmNkjoAsV q82KL5JczLC5mZQzZjd4A9rgOIh9jvi2qvjLK4UzHg93lPmwvZdA/j3O+2lCYuV0u1CJ t0MQ== X-Gm-Message-State: AOAM533FI66DcXz75HXVTHHcvWdddaKD2j5d4R40N5QT414m4uF0XSNs WPq7kYYe31ww4Twasfx6y6J9v+iqbDXf7a4BnmA= X-Google-Smtp-Source: ABdhPJw8FTwSgDZKdL629kUQYMzeUrXwAX+bgkjUvqSfELH5CpEvJHokDsoxSveHmY2KPMtNNmKMVRZiIk65M0LQCQU= X-Received: by 2002:a62:7e41:0:b029:3e0:9c3f:ab50 with SMTP id z62-20020a627e410000b02903e09c3fab50mr28230112pfc.57.1630416399431; Tue, 31 Aug 2021 06:26:39 -0700 (PDT) MIME-Version: 1.0 References: <20210830173844.458727-1-hjl.tools@gmail.com> <20210830173844.458727-2-hjl.tools@gmail.com> <874kb5kcfl.fsf@oldenburg.str.redhat.com> In-Reply-To: <874kb5kcfl.fsf@oldenburg.str.redhat.com> Date: Tue, 31 Aug 2021 06:26:03 -0700 Message-ID: Subject: Re: [PATCH v6 1/2] Add declare_object_symbol_alias for assembly codes [BZ #28128] To: Florian Weimer Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Tue, Aug 31, 2021 at 5:48 AM Florian Weimer wrote: > > * H. J. Lu: > > > diff --git a/include/libc-symbols.h b/include/libc-symbols.h > > index d41ecf4384..1678071d77 100644 > > --- a/include/libc-symbols.h > > +++ b/include/libc-symbols.h > > @@ -324,14 +324,16 @@ for linking") > > This is only necessary when defining something in assembly, or playing > > funny alias games where the size should be other than what the compiler > > thinks it is. */ > > -#define declare_symbol_alias(symbol, original, type, size) \ > > - declare_symbol_alias_1 (symbol, original, type, size) > > #ifdef __ASSEMBLER__ > > -# define declare_symbol_alias_1(symbol, original, type, size) \ > > +# define declare_object_symbol_alias(symbol, original, size) \ > > + declare_object_symbol_alias_1 (symbol, original, size) > > +# define declare_object_symbol_alias_1(symbol, original, s_size) \ > > strong_alias (original, symbol); \ > > - .type C_SYMBOL_NAME (symbol), %##type; \ > > - .size C_SYMBOL_NAME (symbol), size > > + .type C_SYMBOL_NAME (symbol), %object; \ > > + .size C_SYMBOL_NAME (symbol), s_size > > #else /* Not __ASSEMBLER__. */ > > +# define declare_symbol_alias(symbol, original, type, size) \ > > + declare_symbol_alias_1 (symbol, original, type, size) > > # define declare_symbol_alias_1(symbol, original, type, size) \ > > asm (".globl " __SYMBOL_PREFIX #symbol \ > > "\n\t" declare_symbol_alias_1_alias (symbol, original) \ > > (trimming Cc: list) > > This change needs to use ASM_LINE_SEP, otherwise part of the directives > turn into comments on arc and hppa, leading to ABI breakage. > > Something like this: > > diff --git a/include/libc-symbols.h b/include/libc-symbols.h > index 1678071d77..2b47144d6f 100644 > --- a/include/libc-symbols.h > +++ b/include/libc-symbols.h > @@ -328,8 +328,8 @@ for linking") > # define declare_object_symbol_alias(symbol, original, size) \ > declare_object_symbol_alias_1 (symbol, original, size) > # define declare_object_symbol_alias_1(symbol, original, s_size) \ > - strong_alias (original, symbol); \ > - .type C_SYMBOL_NAME (symbol), %object; \ > + strong_alias (original, symbol) ASM_LINE_SEP \ > + .type C_SYMBOL_NAME (symbol), %object ASM_LINE_SEP \ > .size C_SYMBOL_NAME (symbol), s_size > #else /* Not __ASSEMBLER__. */ > # define declare_symbol_alias(symbol, original, type, size) \ > > With this change, the expected ABI is produced. Fixed in the next version. Thanks. > Thanks, > Florian > -- H.J.