On Fri, Jul 9, 2021 at 6:00 AM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>
> On 7/9/21 5:54 PM, H.J. Lu wrote:
> > On Thu, Jul 8, 2021 at 9:07 PM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
> >>
> >>> diff --git a/malloc/Makefile b/malloc/Makefile
> >>> index 37a9a4efab..b685ed6d61 100644
> >>> --- a/malloc/Makefile
> >>> +++ b/malloc/Makefile
> >>> @@ -42,6 +42,7 @@ tests := mallocbug tst-malloc tst-valloc tst-calloc tst-obstack \
> >>>         tst-malloc-stats-cancellation \
> >>>         tst-tcfree1 tst-tcfree2 tst-tcfree3 \
> >>>         tst-safe-linking \
> >>> +      tst-mallocalign1 \
> >>>
> >>
> >> Please remove the trailing '\'.  OK otherwise.
> >>
> >
> > Changes in the v2 patch
> >
> > 1. Add a comment in malloc/tst-mallocalign1.c to indicate that it is
> > used to verify that MALLOC_ALIGNMENT is honored by malloc.
> > 2. Include <malloc-alignment.h> in malloc-size.h after SIZE_SZ is
> > defined since <malloc-alignment.h> may use SIZE_SZ.
> >
> > BTW, I kept the trailing '\' since it is used in all other places in
> > malloc/Makefile.
> >
> > OK for master?
>
> I forgot to ask, does it run successfully on i686 and arm?  IIRC it too
> requires 16 byte alignment and hence both i686 and x32 will fail.

It fails on i686 and x32.

> If they don't succeed then it may make sense to add
>
> tests-exclude-mcheck += tst-mallocalign1
>
> for x32 and i686.
>
> Siddhesh

Here is the v3 patch to add tst-mallocalign1 to tests-exclude-mcheck
for i386 and x32.

OK for master?

-- 
H.J.