From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 08E131F8C6 for ; Thu, 8 Jul 2021 20:31:36 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 05FCE3AA9917 for ; Thu, 8 Jul 2021 20:31:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 05FCE3AA9917 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625776295; bh=QDHsmW4Z0XCSmBhVnmLPuhHGUn17IsXedtoikayD6UA=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vtSho7qx2B5dKxnk95UaDnuS+OxJHvVw0HDFxI/00zCkcUeX26L4K75jkmzPyZLK1 /3NLooFPBGC+p3lugVHoY2F69oTEZBtMpubMtCrb9P25wT4GkwDGXQQa0mLmiAyzG8 DHM13IVNk6uAufgG46BbMC87IYRm7z+iqw3SEz1k= Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 848503848000 for ; Thu, 8 Jul 2021 20:31:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 848503848000 Received: by mail-pf1-x433.google.com with SMTP id 145so6656766pfv.0 for ; Thu, 08 Jul 2021 13:31:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QDHsmW4Z0XCSmBhVnmLPuhHGUn17IsXedtoikayD6UA=; b=mvZZJ7EH6Z38j49BFy49tLwLtasIrD/Ps377N9QT+zZ9GmJlGDysn9zTx3GH6Z/6KB A7fbnKzEWvwyB4kMwhun/tdv8DllrC+XQq0cWz/+TOfBWfeb3egolkJ7q5X7migTKNZq Mnp3spGWE1yGOH9sttim9IB96rVEFaXdOkGKATV4DPrCdVFbXSG0ocPoIuKo7eVPKKpM O7lwvLY+Dl243lpVdAg/gmFt9a6wqgUE72XzdkliRpXIHogME8G0uGNVxpeM4yZkZ9p6 Q+QFgYN87KtL8Y8YQTuiEHWBBFvvqrPieKUka9YoDY7rRUBJ4+h/HQ7vxEAjyjrvNai4 qT0A== X-Gm-Message-State: AOAM530rokFZaA4YwM/Arbbr3yffKlPQuYYJa+UjvJ2VdtgqPhR1U6e+ rOK4Wix7KnEzQYkorZW2tr5Sc7YsFFBF9zjzjoo= X-Google-Smtp-Source: ABdhPJxf3yGPhAhp7yOaTqTqHL+zqDSMXisycciDp5lwGclza/A1yvO1TdAL6rjXEUQgQgvzVP00aM15QTQow4/mJog= X-Received: by 2002:a05:6a00:1c5f:b029:327:bd67:9d6f with SMTP id s31-20020a056a001c5fb0290327bd679d6fmr4996925pfw.48.1625776274684; Thu, 08 Jul 2021 13:31:14 -0700 (PDT) MIME-Version: 1.0 References: <20210708081308.640036-1-goldstein.w.n@gmail.com> <20210708201318.1222367-1-goldstein.w.n@gmail.com> <20210708201318.1222367-2-goldstein.w.n@gmail.com> In-Reply-To: <20210708201318.1222367-2-goldstein.w.n@gmail.com> Date: Thu, 8 Jul 2021 13:30:38 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] x86: Remove wcsnlen-sse4_1 from wcslen ifunc-impl-list [BZ #28064] To: Noah Goldstein Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Thu, Jul 8, 2021 at 1:14 PM Noah Goldstein wrote: > > The following commit > > commit 6f573a27b6c8b4236445810a44660612323f5a73 > Author: Noah Goldstein > Date: Wed Jun 23 01:19:34 2021 -0400 > > x86-64: Add wcslen optimize for sse4.1 > > Added wcsnlen-sse4.1 to the wcslen ifunc implementation list and did > not add wcslen-sse4.1 to wcslen ifunc implementation list. This commit > fixes that by removing wcsnlen-sse4.1 from the wcslen ifunc > implementation list and adding wcslen-sse4.1 to the ifunc > implementation list. > > Testing: > test-wcslen.c, test-rsi-wcslen.c, and test-rsi-strlen.c are passing as > well as all other tests in wcsmbs and string. > > Signed-off-by: Noah Goldstein > Reviewed-by: H.J. Lu > --- > Confirmed test-rsi-wcslen.c failed before this fix. Great. > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > index dbd1ebf298..39ab10613b 100644 > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > @@ -684,9 +684,9 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > && CPU_FEATURE_USABLE (AVX512BW) > && CPU_FEATURE_USABLE (BMI2)), > __wcslen_evex) > - IFUNC_IMPL_ADD (array, i, wcsnlen, > + IFUNC_IMPL_ADD (array, i, wcslen, > CPU_FEATURE_USABLE (SSE4_1), > - __wcsnlen_sse4_1) > + __wcslen_sse4_1) > IFUNC_IMPL_ADD (array, i, wcslen, 1, __wcslen_sse2)) > > /* Support sysdeps/x86_64/multiarch/wcsnlen.c. */ > -- > 2.25.1 > LGTM. Please check in both patches. Reviewed-by: H.J. Lu Thanks. -- H.J.