unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Sunil Pandey via Libc-alpha <libc-alpha@sourceware.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: andrey.kolesov@intel.com, GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 4/6] x86-64: Add vector log/logf to libmvec microbenchmark
Date: Tue, 23 Nov 2021 10:30:44 -0800	[thread overview]
Message-ID: <CAMAf5_e-9jb5aFEjMGNQ56Y8nDsib+Q9VsJzUZmm6HgMMALb0w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111160008420.369620@digraph.polyomino.org.uk>

On Mon, Nov 15, 2021 at 4:12 PM Joseph Myers <joseph@codesourcery.com>
wrote:

> On Fri, 12 Nov 2021, Sunil Pandey via Libc-alpha wrote:
>
> > Can you please provide some suggestions on input range, if it looks OK or
> > it should be changed to some specific value to make it fair for different
> > implementations.
> >
> > cos/cosf: Random inputs in [a=-100.00,b=100.00]
> > sin/sinf: Random inputs in [a=-100.00,b=100.00]
>
> My guess is that most inputs are actually in say [-10, 10], but [-100,
> 100] seems reasonable as limits on what values are benchmarked at all.
>
> > exp/expf: Random inputs in [a=-10.00,b=50.00]
>
> I suggest a roughly symmetric range (lower limit being a bit above what
> would cause a subnormal result, upper limit being a bit below what would
> overflow - note that means different limits for exp and expf).
>
> > log/logf: Random inputs in [a=1.10,b=100.00]
>
> I suggest a lower limit of 0 and an upper limit of FLT_MAX / DBL_MAX (note
> this means different limits for log and logf), but with a substantial
> proportion of inputs being closer to 1 (say in the range [0.01, 100]).
>
> > pow/powf: Random inputs in [a=0.01,b=100.00], [c=0.01,d=10.00]
>
> I think negative exponents should be included, about as many as positive
> exponents (similar range, so that results are neither subnormal nor
> overflowing).
>

Hi Joseph,

I submitted patch v4 to address the input data set issue for vector cos,
cosf,
sin, sinf, exp, expf, log, logf, pow and powf.

Let me know if it looks ok to you.

--Sunil


> --
> Joseph S. Myers
> joseph@codesourcery.com
>

  parent reply	other threads:[~2021-11-23 18:31 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10  3:07 [PATCH 0/6] Implement microbenchmark for libmvec Sunil K Pandey via Libc-alpha
2021-11-10  3:07 ` [PATCH 1/6] x86-64: Create microbenchmark infrastructure " Sunil K Pandey via Libc-alpha
2021-11-10  3:53   ` Noah Goldstein via Libc-alpha
2021-11-11 18:34     ` Sunil Pandey via Libc-alpha
2021-11-12 19:17       ` [PATCH v2 0/6] Implement microbenchmark " Sunil K Pandey via Libc-alpha
2021-11-12 19:17         ` [PATCH v2 1/6] x86-64: Create microbenchmark infrastructure " Sunil K Pandey via Libc-alpha
2021-11-12 21:02           ` Noah Goldstein via Libc-alpha
2021-11-12 22:49             ` Sunil Pandey via Libc-alpha
2021-11-13 19:47               ` H.J. Lu via Libc-alpha
2021-11-14  2:59                 ` Sunil Pandey via Libc-alpha
2021-11-15 21:06             ` [PATCH v3 0/6] Implement microbenchmark " Sunil K Pandey via Libc-alpha
2021-11-15 21:06               ` [PATCH v3 1/6] x86-64: Create microbenchmark infrastructure " Sunil K Pandey via Libc-alpha
2021-11-16 17:21                 ` H.J. Lu via Libc-alpha
2021-11-16 18:37                   ` [PATCH] " Sunil K Pandey via Libc-alpha
2021-11-16 18:40                     ` H.J. Lu via Libc-alpha
2021-11-15 21:06               ` [PATCH v3 2/6] x86-64: Add vector cos/cosf to libmvec microbenchmark Sunil K Pandey via Libc-alpha
2021-11-15 21:06               ` [PATCH v3 3/6] x86-64: Add vector exp/expf " Sunil K Pandey via Libc-alpha
2021-11-15 21:06               ` [PATCH v3 4/6] x86-64: Add vector log/logf " Sunil K Pandey via Libc-alpha
2021-11-15 21:06               ` [PATCH v3 5/6] x86-64: Add vector pow/powf " Sunil K Pandey via Libc-alpha
2021-11-15 21:06               ` [PATCH v3 6/6] x86-64: Add vector sin/sinf " Sunil K Pandey via Libc-alpha
2021-11-12 19:17         ` [PATCH v2 2/6] x86-64: Add vector cos/cosf " Sunil K Pandey via Libc-alpha
2021-11-12 19:17         ` [PATCH v2 3/6] x86-64: Add vector exp/expf " Sunil K Pandey via Libc-alpha
2021-11-12 19:17         ` [PATCH v2 4/6] x86-64: Add vector log/logf " Sunil K Pandey via Libc-alpha
2021-11-12 23:18           ` Joseph Myers
2021-11-13  1:37             ` Sunil Pandey via Libc-alpha
2021-11-13  1:44               ` Joseph Myers
2021-11-13  6:14                 ` Sunil Pandey via Libc-alpha
2021-11-16  0:12                   ` Joseph Myers
2021-11-23 17:40                     ` [PATCH v4 0/5] Add vector math functions to microbenchmark Sunil K Pandey via Libc-alpha
2021-11-23 17:40                       ` [PATCH v4 1/5] x86-64: Add vector cos/cosf to libmvec microbenchmark Sunil K Pandey via Libc-alpha
2021-11-24 12:22                         ` H.J. Lu via Libc-alpha
2021-11-23 17:40                       ` [PATCH v4 2/5] x86-64: Add vector exp/expf " Sunil K Pandey via Libc-alpha
2021-11-24 12:24                         ` H.J. Lu via Libc-alpha
2021-11-23 17:40                       ` [PATCH v4 3/5] x86-64: Add vector log/logf " Sunil K Pandey via Libc-alpha
2021-11-24 12:25                         ` H.J. Lu via Libc-alpha
2021-11-23 17:40                       ` [PATCH v4 4/5] x86-64: Add vector pow/powf " Sunil K Pandey via Libc-alpha
2021-11-24 12:26                         ` H.J. Lu via Libc-alpha
2021-11-23 17:40                       ` [PATCH v4 5/5] x86-64: Add vector sin/sinf " Sunil K Pandey via Libc-alpha
2021-11-24 12:30                         ` H.J. Lu via Libc-alpha
2021-11-23 18:30                     ` Sunil Pandey via Libc-alpha [this message]
2021-11-23 22:13                       ` [PATCH v2 4/6] x86-64: Add vector log/logf " Joseph Myers
2021-11-12 19:17         ` [PATCH v2 5/6] x86-64: Add vector pow/powf " Sunil K Pandey via Libc-alpha
2021-11-12 19:18         ` [PATCH v2 6/6] x86-64: Add vector sin/sinf " Sunil K Pandey via Libc-alpha
2021-11-10  3:07 ` [PATCH 2/6] x86-64: Add cos/cosf " Sunil K Pandey via Libc-alpha
2021-11-10  3:07 ` [PATCH 3/6] x86-64: Add exp/expf " Sunil K Pandey via Libc-alpha
2021-11-10  3:07 ` [PATCH 4/6] x86-64: Add log/logf " Sunil K Pandey via Libc-alpha
2021-11-10  3:07 ` [PATCH 5/6] x86-64: Add pow/powf " Sunil K Pandey via Libc-alpha
2021-11-10 20:27   ` Joseph Myers
2021-11-11  3:31     ` Sunil Pandey via Libc-alpha
2021-11-11 10:39       ` Szabolcs Nagy via Libc-alpha
2021-11-11 17:40         ` Sunil Pandey via Libc-alpha
2021-11-11 18:51           ` Sunil Pandey via Libc-alpha
2021-11-10  3:07 ` [PATCH 6/6] x86-64: Add sin/sinf " Sunil K Pandey via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMAf5_e-9jb5aFEjMGNQ56Y8nDsib+Q9VsJzUZmm6HgMMALb0w@mail.gmail.com \
    --to=libc-alpha@sourceware.org \
    --cc=andrey.kolesov@intel.com \
    --cc=joseph@codesourcery.com \
    --cc=skpgkp2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).