From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C292C1F4B4 for ; Sat, 17 Apr 2021 18:02:20 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93A5E3896C28; Sat, 17 Apr 2021 18:02:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93A5E3896C28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618682539; bh=umgyAWENld3fVPgU6tBnHoTp2BOktYlZOjAqOjscN1U=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HCeBIF6TtQuGeEeVpJB6Dzbe8lQRI5DyKYqeCJb1rXIJuxmxrU0wrrlDzgkAN8yTH YIUSYG+JKHD7Nk5j4I+nSKICz0ocN+v9724md99tHFgGf0GPGF+raU7pP0wgx1PM1O yqH8Nok7HGt4TiP8jDj4TG3zgR/VzOhwCxKzBqxQ= Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 6BB133894C21 for ; Sat, 17 Apr 2021 18:02:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6BB133894C21 Received: by mail-wm1-x336.google.com with SMTP id w186so11411292wmg.3 for ; Sat, 17 Apr 2021 11:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=umgyAWENld3fVPgU6tBnHoTp2BOktYlZOjAqOjscN1U=; b=QdzOYzEoyfOX8jQYAgNEcqQ8AExxbmkRb6C0QEfrE6DiluRyw0pWfMUFgAUWbIXn+h MeH9solQePp5+rk8fjqSdMZAK/nJT7x1ovNuU5+0SKJxo+DFZOti0h87CqKTo8S6JTiG QmxxtNp35rz1rQDYVazuFKAr7FknzrNB6xmJwLyfvvDiqiikj62txTl/bthhCpDFv9TN M9UJJf7OfXwm2dziK2hIkoN26DCT40QASXndpr02nPIlsvfsKLTq8QoiJ0Z9jSMgVLhK 7Qr2OWUkdzecE2EDDZMklID8MREznDBgG8D61yFiFSl63QDPEjfeO2gX0h1LVdoitvGH P5Rw== X-Gm-Message-State: AOAM531rjrRPboT910eWwYsTEvoOZqhRGix+tSuBAxPVBGAxbzpgkMe0 PIoDgLZcoDpDI5oGsOFleSgj67dJqv+fpmzdmYYdjBqnC9ij3w== X-Google-Smtp-Source: ABdhPJwL97ETNNQP/8PD4RfFKCw4IiZyz3KmMm1Zn4X+OHoU0IyisNEu9HEcZbRF+U4VyDQqxZWNQmq2OLSdOgEmcY0= X-Received: by 2002:a1c:c246:: with SMTP id s67mr13255499wmf.86.1618682527050; Sat, 17 Apr 2021 11:02:07 -0700 (PDT) MIME-Version: 1.0 References: <20210417172258.2788076-1-vitalybuka@google.com> In-Reply-To: <20210417172258.2788076-1-vitalybuka@google.com> Date: Sat, 17 Apr 2021 11:01:39 -0700 Message-ID: Subject: Re: [PATCH] stdlib: Fix data race in __run_exit_handlers To: Vitaly Buka Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Paul Pluzhnikov via Libc-alpha Reply-To: Paul Pluzhnikov Cc: GLIBC Devel Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Sat, Apr 17, 2021 at 10:23 AM Vitaly Buka via Libc-alpha wrote: > diff --git a/stdlib/test-cxa_atexit-race2.c b/stdlib/test-cxa_atexit-race2.c > + This test spawns multiple threads, and check the same desctructor is Typo. Suggest: This test spawns multiple threads, and checks that the same destructor is > + not called more then once. */ s/then/than/ > +static void *cb_arg = NULL; > +static void > +add_handlers (void) > +{ > + int n = 10; > + for (int i = 0; i < n; ++i) > + __cxa_atexit (&atexit_cb, ++cb_arg, 0); add_handlers() is called from many threads. This code appears to race on cb_arg. -- Paul Pluzhnikov