From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_REPLYTO_END_DIGIT, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DC7E71F55B for ; Sat, 23 May 2020 10:03:06 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 795E2386F44A; Sat, 23 May 2020 10:03:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 795E2386F44A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590228185; bh=fRlUYKPk9o9OPBgnm6qkU3FrSuHoHAuNwOTp1xqlQd8=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=u8dadURWnXDjILH+pV+6RA3Lk3mycHzylgw9sUdaJ7n46A2pRE+RsiDJRd39I0uPj KVLXM7KkmAwokxl3eW97M1Bfn3M5uy0jLvZRGmo0tuLNkxFsPWS6dAdZJNoahWYuJo gnAUE8sZF9MA/hAJk1vd3GuiNYjdXzivKw1hDxsI= Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by sourceware.org (Postfix) with ESMTPS id BE3BB385DC1C for ; Sat, 23 May 2020 10:03:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BE3BB385DC1C Received: by mail-wm1-x342.google.com with SMTP id u188so12382361wmu.1 for ; Sat, 23 May 2020 03:03:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fRlUYKPk9o9OPBgnm6qkU3FrSuHoHAuNwOTp1xqlQd8=; b=OT6wCcQVusBS5KldoWqk75no88WcyN6LCg85Eq9GHEKHBH3z9jNDKd8sjHKY789PH5 pO1ujksUb7GXpzLCMH3gBTTyyXOXdFcHdStrFt3nwwMgWJb4J9jdq8NcsxEpbMZsJBKC SS2GXF2hZ09Fv6YfLT40bs4xbRyUBWbwGqYTy/EhKykUDUwan3iFozfxXq8VnzsxcVFp 3Gmj6sW+u2TWaWUtsik1Pac0xE8YmX835hszEpLextIO0Ba/P2PSHQXJUxFeyKUIuv+r 3UnMYmwmCLp9nWgQpRwiHpcV+1/I/94mSuqOT7jJY6/yWTBntif9RrBG+9/p1JTvedPB khSw== X-Gm-Message-State: AOAM531Mx/lT4z45ILNon2g+vZV8uRui+QFKmWXLZQc2z9ijkIY00W+Y gVRmEUGPTHmsYzeWwkKoby/WpAKgAx1WhS/LG455LI8XIZY= X-Google-Smtp-Source: ABdhPJzjISEI54kaT5gssclG6rEMhizTTpQQHJxU/LIjBuVRU5Bi9bSFxrsxs1nRiu6guM36NA+hbeV8xIuUjAXmGik= X-Received: by 2002:a1c:1902:: with SMTP id 2mr16959856wmz.178.1590228181824; Sat, 23 May 2020 03:03:01 -0700 (PDT) MIME-Version: 1.0 References: <87mu6eekii.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87mu6eekii.fsf@oldenburg2.str.redhat.com> Date: Sat, 23 May 2020 15:32:50 +0530 Message-ID: Subject: Re: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child [BZ #23990] To: Florian Weimer Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Girish Joshi via Libc-alpha Reply-To: Girish Joshi Cc: Girish Joshi via Libc-alpha Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Thanks Florian for the review. > Sorry, this patch arrived corrupted on the list. > > The error message is not correct because the child process returned an > error status. This can mean that execvp failed, or something else. It > would also make sense to add the status value to the error message. > Reposting the patch with corrected error message. Please let me know if it works. >From f1cc58ee37ded9a6bb3f5764143c6ea8c3572741 Mon Sep 17 00:00:00 2001 From: Girish Joshi Date: Sun, 10 May 2020 01:22:04 +0530 Subject: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child BZ #23990 --- support/test-container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/test-container.c b/support/test-container.c index afc23db148..e9109f9e3d 100644 --- a/support/test-container.c +++ b/support/test-container.c @@ -392,7 +392,7 @@ recursive_remove (char *path) /* "rm" would have already printed a suitable error message. */ if (! WIFEXITED (status) || WEXITSTATUS (status) != 0) - exit (1); + FAIL_EXIT1 ("exec child returned status: %d", status); break; } -- 2.21.3 Thanks. Girish Joshi