From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_REPLYTO_END_DIGIT, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A474D1F55B for ; Sat, 23 May 2020 10:05:31 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDE0F386F002; Sat, 23 May 2020 10:05:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDE0F386F002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590228330; bh=HnzXVkSXSaE5G0falp1+vP1MrV2XwJxfu+ipKLjuajo=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RXmwEsGjXXDOQ7cRincWdcj3Za9lDOiE+zVKei9SjeI2g5YiDSYkH4kmwqJNdSasx nPWRsx/mu0MwqYffxrUI70BKE5Int2UXVRC8ASRGf7Hum1HbyBj0xAKqPq8a2jnjWA /CcYVmlnivPhZKmHhHwytLbnNHjeLZBbNAH3AmYg= Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id 9DAE7385DC1C for ; Sat, 23 May 2020 10:05:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9DAE7385DC1C Received: by mail-wm1-x343.google.com with SMTP id u1so10980697wmn.3 for ; Sat, 23 May 2020 03:05:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HnzXVkSXSaE5G0falp1+vP1MrV2XwJxfu+ipKLjuajo=; b=Ivyp3b8yyzjgo85dSki5pPee8gng00teGKpR/XexGx9wZ0OafKFbi3mDHc05JFQyRw pMjotM+BPuhCRKg73DRg9dV0UiF+mkoTAzrphkotFM+2N2zZK7Vt1RaFdvDubd06e3Rl jE61tyvWJ/BmBKbZIzu3kTZrFDfMNztBSNP1odBPdKl+nKE9Ym0xqnN3LyG4DTJABPQv 9RTQxJLJ6dunM2FOjRhFTItJI7NNwczOIVWaRLy0vZTgqLPJcUKngySF6pOl6AW0r7VQ /BvN1Pb+MN2H1pD5Zd2SQh0ooQTzIY2uShUaRwENTeTDSOxL3oQE33Ebg1TnJxGKwd+/ TnYw== X-Gm-Message-State: AOAM532qeAjCTUps4CAEKftmhQ3ww922d31H5sDwnB7Bijp7kGAeiUOo rqfn5u5l+JZIOT9/76EpHfbGAwrr/URtVYjLnCv9d6Kb6Ug= X-Google-Smtp-Source: ABdhPJwRRKs+kjzrm3+H4LlkXaLWJNFp/ykgm7SUvRc4qbLqyD1WG4oc22SIJIfcs4QlxpVO2GuvIBEvKTq0j1/Srp0= X-Received: by 2002:a1c:1904:: with SMTP id 4mr16283167wmz.125.1590228327733; Sat, 23 May 2020 03:05:27 -0700 (PDT) MIME-Version: 1.0 References: <87mu6eekii.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87mu6eekii.fsf@oldenburg2.str.redhat.com> Date: Sat, 23 May 2020 15:35:16 +0530 Message-ID: Subject: Re: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child [BZ #23990] To: Florian Weimer Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Girish Joshi via Libc-alpha Reply-To: Girish Joshi Cc: Girish Joshi via Libc-alpha Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Thanks Florian for the review. > Sorry, this patch arrived corrupted on the list. > > The error message is not correct because the child process returned an > error status. This can mean that execvp failed, or something else. It > would also make sense to add the status value to the error message. > > Thanks, > Florian > Reposting the patch with corrected error message. Please let me know if it works. >From f1cc58ee37ded9a6bb3f5764143c6ea8c3572741 Mon Sep 17 00:00:00 2001 From: Girish Joshi Date: Sun, 10 May 2020 01:22:04 +0530 Subject: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child BZ #23990 --- support/test-container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/test-container.c b/support/test-container.c index afc23db148..e9109f9e3d 100644 --- a/support/test-container.c +++ b/support/test-container.c @@ -392,7 +392,7 @@ recursive_remove (char *path) /* "rm" would have already printed a suitable error message. */ if (! WIFEXITED (status) || WEXITSTATUS (status) != 0) - exit (1); + FAIL_EXIT1 ("exec child returned status: %d", status); break; } -- 2.21.3 Thanks. Girish Joshi