From: Alistair Francis <alistair23@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: Fix RISC-V vfork build with Linux 5.3 kernel headers
Date: Tue, 17 Sep 2019 15:29:24 -0700 [thread overview]
Message-ID: <CAKmqyKOrE27UmMiLrkKeQ3byrFxCFtcO+DNG6Xh1yiUyLoXbVA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1909172214410.3323@digraph.polyomino.org.uk>
On Tue, Sep 17, 2019 at 3:15 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> Building glibc for RISC-V with Linux 5.3 kernel headers fails because
> <linux/sched.h>, included in vfork.S for CLONE_* constants, contains a
> structure definition not safe for inclusion in assembly code.
>
> All other architectures already avoid use of that header in vfork.S,
> either defining the CLONE_* constants locally or embedding the
> required values directly in the relevant instruction, where they
> implement vfork using the clone syscall (see the implementations for
> aarch64, ia64, mips and nios2). This patch makes the RISC-V version
> define the constants locally like the other architectures.
>
> Tested build for all three RISC-V configurations in
> build-many-glibcs.py with Linux 5.3 headers.
LGTM.
I was confused why I haven't seen this, but I'm using the 5.2 headers
which is why I haven't hit this.
Alistair
>
> 2019-09-17 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/unix/sysv/linux/riscv/vfork.S: Do not include
> <linux/sched.h>.
> (CLONE_VM): New macro.
> (CLONE_VFORK): Likewise.
>
> diff --git a/sysdeps/unix/sysv/linux/riscv/vfork.S b/sysdeps/unix/sysv/linux/riscv/vfork.S
> index e68dbc7d5d..062a562e72 100644
> --- a/sysdeps/unix/sysv/linux/riscv/vfork.S
> +++ b/sysdeps/unix/sysv/linux/riscv/vfork.S
> @@ -21,9 +21,12 @@
> #include <sys/asm.h>
> #include <sysdep.h>
> #define __ASSEMBLY__
> -#include <linux/sched.h>
> #include <asm/signal.h>
>
> +#define CLONE_VM 0x00000100 /* Set if VM shared between processes. */
> +#define CLONE_VFORK 0x00004000 /* Set if the parent wants the child to
> + wake it up on mm_release. */
> +
> .text
> LEAF (__libc_vfork)
>
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2019-09-17 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 22:15 Fix RISC-V vfork build with Linux 5.3 kernel headers Joseph Myers
2019-09-17 22:29 ` Alistair Francis [this message]
2019-09-20 22:45 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKOrE27UmMiLrkKeQ3byrFxCFtcO+DNG6Xh1yiUyLoXbVA@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).