unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v6 2/3] time: Define time64 thrd_sleep
Date: Fri, 8 Nov 2019 13:17:10 -0800	[thread overview]
Message-ID: <CAKmqyKOjMkfNvZ3_CEV7OX+jpRZgdJ7CMookZyP8imJufXVh1Q@mail.gmail.com> (raw)
In-Reply-To: <1705ec39-fe0b-b6c1-0ca6-f291b183f2db@linaro.org>

On Fri, Nov 8, 2019 at 10:58 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 08/11/2019 14:03, Alistair Francis wrote:
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> >  include/time.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/include/time.h b/include/time.h
> > index d7800eb30f8..cbacf4fc9d7 100644
> > --- a/include/time.h
> > +++ b/include/time.h
> > @@ -210,8 +210,12 @@ libc_hidden_proto (__difftime64)
> >  extern double __difftime (time_t time1, time_t time0);
> >
> >  #if __TIMESIZE == 64
> > +# define __thrd_sleep_time64 thrd_sleep
> >  # define __clock_nanosleep_time64 __clock_nanosleep
> >  #else
> > +extern int __thrd_sleep_time64 (const struct __timespec64* time_point,
> > +                                struct __timespec64* remaining);
> > +libc_hidden_proto (__thrd_sleep_time64)
> >  extern int __clock_nanosleep_time64 (clockid_t clock_id,
> >                                       int flags, const struct __timespec64 *req,
> >                                       struct __timespec64 *rem);
> >
>
> I am missing the point of this patch, why are you adding the prototype
> without the thrd_sleep time64 implementation?

I actually don't think these twp patches are required. They were just
left over that I kept porting that are no longer needed. I'll drop
these two.

Alistair

  reply	other threads:[~2019-11-08 21:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 17:03 [PATCH v6 1/3] sysdeps/clock_nanosleep: Use clock_nanosleep_time64 if avaliable Alistair Francis
2019-11-08 17:03 ` [PATCH v6 2/3] time: Define time64 thrd_sleep Alistair Francis
2019-11-08 18:58   ` Adhemerval Zanella
2019-11-08 21:17     ` Alistair Francis [this message]
2019-11-08 17:03 ` [PATCH v6 3/3] time: Define time64 nanosleep Alistair Francis
2019-11-08 18:59   ` Adhemerval Zanella
2019-11-08 19:01 ` [PATCH v6 1/3] sysdeps/clock_nanosleep: Use clock_nanosleep_time64 if avaliable Adhemerval Zanella
2019-11-08 20:52   ` Alistair Francis
2019-11-10  9:00 ` Andreas Schwab
2019-11-10 16:44   ` Alistair Francis
2019-11-10 17:44     ` Andreas Schwab
2019-11-11 13:50       ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKOjMkfNvZ3_CEV7OX+jpRZgdJ7CMookZyP8imJufXVh1Q@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).