From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 053911F461 for ; Wed, 17 Jul 2019 22:27:18 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=nvmY ZTF32a0Vx+aV83qTVvgcZBk/xGaMT+Vtae77HMhvCK2MzPqq4nB9vBI6jRFy21uJ KUVUFMvnUGs9wWG+hQjeTdHgMtucken45c73kYZ2zeDATHrPmJTnuWZ+kz9VTaNx FPepNGjoDd21TmyeuYOebPv/u5y6kFws7VuwwAs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=8P0zXozNbd diF17ggqGHamaymmk=; b=xS80UElw/axqtwKvlj4vdtJBQkREFwtaIFxEjYqxpj SFv/lmnrp3g+FnlN5GKJ3u2Tqf19uDyoyt23yur7eKQJBohqYybrtuET320U19Zk OoZvaSzekLeQuTv5fiwr2rurTJACU/L5KhzVOQzlu5CPIMU+aHoZmumnLAnsk2La 4= Received: (qmail 52441 invoked by alias); 17 Jul 2019 22:27:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 52432 invoked by uid 89); 17 Jul 2019 22:27:16 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-lj1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ouga9nMFgvn7xHNBGvpKQhNBpjEwIqkCkY9+iKstW6g=; b=nRL6ApcDGpnVA5wn2VAqHlNCxcvY2ALznhfqri1oys2DQFlfzswzLK+3pA42rcr3d7 +ITwZjTAMl8HTUf5rs2QerH+IO95LQb6D+jJLitcAqWdszAgyswgBpWy4STO+x879EBX QmwdPyk34Ms8th1Oah8QhC2QjcGAt+Ln0I04rFIH1xlFfUdqPnB5yOw7GP5jprxACRwy lJimVzxYV06axVwVqXFXpE9Xz9Rs/KZAWbxgN/7Fuj6eHEnqt4OfqUrkDGZ5zm8bmy3m Qoou4mOEorgx+jNFGOTUqidVt1+2LyAhk8+ptPRAqD9J2EBOFdyf50O/4+EUtcbuCyjx gsjg== MIME-Version: 1.0 References: <2bf63d1fc37727b7ed77dd20a69ae525a0cee859.1563321716.git.alistair.francis@wdc.com> <87k1chdy3f.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: Alistair Francis Date: Wed, 17 Jul 2019 15:23:52 -0700 Message-ID: Subject: Re: [RFC v3 23/23] RISC-V: Use 64-bit vdso syscalls To: Arnd Bergmann Cc: Florian Weimer , Alistair Francis , GNU C Library , Adhemerval Zanella , Palmer Dabbelt , macro@wdc.com, Zong Li Content-Type: text/plain; charset="UTF-8" On Wed, Jul 17, 2019 at 1:02 AM Arnd Bergmann wrote: > > On Wed, Jul 17, 2019 at 7:33 AM Florian Weimer wrote: > > > > * Alistair Francis: > > > > > Signed-off-by: Alistair Francis > > > --- > > > sysdeps/unix/sysv/linux/riscv/init-first.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/sysdeps/unix/sysv/linux/riscv/init-first.c b/sysdeps/unix/sysv/linux/riscv/init-first.c > > > index 155a4a2c0c..fa9c690cdd 100644 > > > --- a/sysdeps/unix/sysv/linux/riscv/init-first.c > > > +++ b/sysdeps/unix/sysv/linux/riscv/init-first.c > > > @@ -43,11 +43,11 @@ _libc_vdso_platform_setup (void) > > > PTR_MANGLE (p); > > > VDSO_SYMBOL (gettimeofday) = p; > > > > > > - p = _dl_vdso_vsym ("__vdso_clock_gettime", &linux_version); > > > + p = _dl_vdso_vsym ("__vdso_clock_gettime64", &linux_version); > > > PTR_MANGLE (p); > > > VDSO_SYMBOL (clock_gettime) = p; > > > > > > - p = _dl_vdso_vsym ("__vdso_clock_getres", &linux_version); > > > + p = _dl_vdso_vsym ("__vdso_clock_getres_time64", &linux_version); > > > PTR_MANGLE (p); > > > VDSO_SYMBOL (clock_getres) = p; > > > } > > > > I believe this will lose vDSO acceleration for RV64 on older kernels > > which do not define __vdso_clock_getres_time64. > > Also newer kernels, as 64-bit kernels only have __vdso_clock_getres, > not __vdso_clock_getres_time64. Ok, I can #ifdef this based on word size. Alistair > > Arnd