From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9BEF81F454 for ; Fri, 8 Nov 2019 16:21:21 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=JWGm oYh2WbozL52gogXOMHsZ/O/lms7CppvQe3SgwABzk2LJEmFLqY1M50O3R55aKpco R+BwRwFhRKN7H8RIGdq5Ujl1UhNzAJ9fZA+jExiECHLqOh5zbH9zaD5LERtC37Yr rO9c+OMV/MKpaMURvq9temxbYnXK4o1AzfjqveE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=UfDeZ3nS4s HXGipIr+N1UY4Fobc=; b=krGOzbrd2sZxuUoj720p8TDO/MAZA/JprKLZgDVxw5 qHsjGA1TBl3Dyt8N5SXQL8g4LD5Uw3Swe4VDpODoIJ2UlHKuHxY/ysB/Dd8119aa uDuyfUl5++HK/UG5P/AJisuIZLmX5M2SE/gVVDOhr1CGudATFphlZqrK1A6FzyfH M= Received: (qmail 12964 invoked by alias); 8 Nov 2019 16:21:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 12955 invoked by uid 89); 8 Nov 2019 16:21:19 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-lj1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qWrkCrUF4LP6cowtICDdY2HpdZR2k6YhpV/PsnTdUSw=; b=faPiUU8FZ7NoxFKm3iVyatEHmd5rwfPDzFJiRUr9GzQnUpKI6BI+hRS0x4cckG4EJr 6AriuNTcCe7bHLjBWSZSRb/DPojxHN/ydY2HO3TcOgldXYOYWgou7ILyCXxpEXVyJmhU Pn/3IpVl0CwgylzRDTE62xXxfNyjaYhjif1bMSt+CYt/QBXpe/cX9hOs1HCOc3+5bcTA Kk8dOKbissu3aHZHWmbopB46lVJhzKPywCrQyZH06ovs+5kVtfe9twKTWiWaSjyFctvd t0LpbhYII23xrnSS41OEckspOPCHBQqEHhgpxIqW3JL0jnhokYog9SBvosDbl4oc4XGS 3Xww== MIME-Version: 1.0 References: <20191108153344.10949-1-lukma@denx.de> In-Reply-To: <20191108153344.10949-1-lukma@denx.de> From: Alistair Francis Date: Fri, 8 Nov 2019 08:20:49 -0800 Message-ID: Subject: Re: [PATCH 1/2] linux: clock_settime: Remove check for nanoseconds validity To: Lukasz Majewski Cc: Joseph Myers , Paul Eggert , Alistair Francis , GNU C Library , Adhemerval Zanella , Florian Weimer , Florian Weimer , Zack Weinberg , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" On Fri, Nov 8, 2019 at 7:34 AM Lukasz Majewski wrote: > > The check if passed nanoseconds via struct __timespec64's *tp pointer is > also performed in the Linux kernel. Remove it from glibc to avoid > duplication. Reviewed-by: Alistair Francis Alistair > --- > sysdeps/unix/sysv/linux/clock_settime.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/sysdeps/unix/sysv/linux/clock_settime.c b/sysdeps/unix/sysv/linux/clock_settime.c > index bda113809b..6706dbb31f 100644 > --- a/sysdeps/unix/sysv/linux/clock_settime.c > +++ b/sysdeps/unix/sysv/linux/clock_settime.c > @@ -25,13 +25,6 @@ > int > __clock_settime64 (clockid_t clock_id, const struct __timespec64 *tp) > { > - /* Make sure the time cvalue is OK. */ > - if (! valid_nanoseconds (tp->tv_nsec)) > - { > - __set_errno (EINVAL); > - return -1; > - } > - > #ifdef __ASSUME_TIME64_SYSCALLS > # ifndef __NR_clock_settime64 > # define __NR_clock_settime64 __NR_clock_settime > -- > 2.20.1 >