From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS, UPPERCASE_50_75 shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C1DF81F461 for ; Wed, 17 Jul 2019 22:43:23 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=guBs 39tI5qPQVwdO2D7fWEobX9RLeKogQ+7J0VaJTEJ8Y6S5A5lEaPF4Sm7xP2Wd24m4 eNHM2d9ibl+UTzqfa0LdeU21QlmRblGZV4Eu/v7OOorUA72pMqTcTjxrbWLFPNWX FkRgTscKXOHPQX3TW7fd1kikLzqhILcOsZq9NbU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=PrbXorZEwM ds0SlFZH1uxyVVnDo=; b=SSTmyGVpqkhJ8HNC3t6PdTmlBQwwSzgRlHM8SsW0Wu 9HeOlP8x/G2/x7RACB+HrFaF76W4kNwzxdLtvCCGFPerdE78WOtP1oIY3sBulKfr T6H4MQAY8d0lwb3+KXaabIlwz54ifAr5S6YY+B89zQfDfENMbGymkwW7HXsdkScg g= Received: (qmail 75806 invoked by alias); 17 Jul 2019 22:43:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 75796 invoked by uid 89); 17 Jul 2019 22:43:20 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-io1-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RHbTO3p1771B0IEnKdHam2MLY55aHvbAtiZZqZzFfHE=; b=OCblCsp6TZOoo0xKGVhjbDp9CykYMJcN5bLlUBiEK9R+cF4inMPEaQ2dzap8kPszgX ux6XSGFdKuUmyGy3/lSdzcSWr74TE6oPJQ6LYnSX4ys+c+JOp7hf93/SHJgb5YfyeB3L 7DoeJ7NMnW8zNKje8pYR7KnGo14fQTgFQ4css86u/vdHrP7Wn252x3fer0UcLDsB/x1h hSQWQxUWLpo5AZ1hrxsHXbejawtspjoPpvooELrY5QjAln+3FZYJwcFDn16+iOZZe5oh VU0Rm0+rcUPIqeN0rHbzpnaXWQ2UU32gUMvj2tFo8eJH9ccmjlIPvnejeN2DGFrdconp ruiA== MIME-Version: 1.0 References: In-Reply-To: From: Alistair Francis Date: Wed, 17 Jul 2019 15:39:58 -0700 Message-ID: Subject: Re: [RFC v3 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 To: Arnd Bergmann Cc: Alistair Francis , GNU C Library , Adhemerval Zanella , Florian Weimer , Palmer Dabbelt , macro@wdc.com, Zong Li Content-Type: text/plain; charset="UTF-8" On Wed, Jul 17, 2019 at 1:27 AM Arnd Bergmann wrote: > > On Wed, Jul 17, 2019 at 2:11 AM Alistair Francis > wrote: > > > +#define __DEV_T_TYPE __UQUAD_TYPE > > +#define __UID_T_TYPE __U32_TYPE > > +#define __GID_T_TYPE __U32_TYPE > > +#define __INO_T_TYPE __UQUAD_TYPE > > +#define __INO64_T_TYPE __UQUAD_TYPE > > +#define __MODE_T_TYPE __U32_TYPE > > +#define __NLINK_T_TYPE __U32_TYPE > > +#define __OFF_T_TYPE __SQUAD_TYPE > > +#define __OFF64_T_TYPE __SQUAD_TYPE > > +#define __PID_T_TYPE __S32_TYPE > > +#define __RLIM_T_TYPE __UQUAD_TYPE > > +#define __RLIM64_T_TYPE __UQUAD_TYPE > > +#define __BLKCNT_T_TYPE __SQUAD_TYPE > > +#define __BLKCNT64_T_TYPE __SQUAD_TYPE > > +#define __FSBLKCNT_T_TYPE __UQUAD_TYPE > > +#define __FSBLKCNT64_T_TYPE __UQUAD_TYPE > > +#define __FSFILCNT_T_TYPE __UQUAD_TYPE > > +#define __FSFILCNT64_T_TYPE __UQUAD_TYPE > > +#define __FSWORD_T_TYPE __SWORD_TYPE > > +#define __ID_T_TYPE __U32_TYPE > > +#define __CLOCK_T_TYPE __SLONGWORD_TYPE > > +#define __TIME_T_TYPE __SQUAD_TYPE > > +#define __USECONDS_T_TYPE __U32_TYPE > > +#define __SUSECONDS_T_TYPE __SQUAD_TYPE > > +#define __DADDR_T_TYPE __S32_TYPE > > +#define __KEY_T_TYPE __S32_TYPE > > +#define __CLOCKID_T_TYPE __S32_TYPE > > +#define __TIMER_T_TYPE void * > > +#define __BLKSIZE_T_TYPE __S32_TYPE > > +#define __FSID_T_TYPE struct { int __val[2]; } > > +#define __SSIZE_T_TYPE __SWORD_TYPE > > +#define __SYSCALL_SLONG_TYPE __SQUAD_TYPE > > +#define __SYSCALL_ULONG_TYPE __UQUAD_TYPE > > +#define __CPU_MASK_TYPE __UQUAD_TYPE > > I see you fixed __CLOCK_T_TYPE, but you still have a number > of types that differ from the kernel ABI for no apparent reason. > > Is this intentional? Yes, if I use the generic ones for RV32 I see build failures as some of the structs don't align (I can't remember which ones now). So this is required to build. Alistair > > Arnd