From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7E2CF1F463 for ; Tue, 24 Sep 2019 20:35:26 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=ERGZ 7Xuh+I5lSA7HS/Th2d/QCZlgKcRv6+9JdJ6y0XNJ7MxCk9Us35jh8GbSCOL8IesJ prJPlCjqKrXlqWafxgIqNonrZ06qteX5F9bx+f23gEebRRyhzHyTz4WubADoT1hW Bz50NPFkYpsKpEBS/XzDFPL2WCuCZUCyJybG3Kc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=tQ3kMPB4iD 2m14DkWlUzw48+pag=; b=h6SSaKdDP6zT9j5mragQsLrRxVC4dNyuzlDEFM8MmV ZroGD5Pj9bQnRO7W6VZO9wBpr75oKzujFzg+uDQo3+0t+vrAs8bir+RJ4kWuUHXi s48Mxg3IXSpUSA4Wmwd/mbE3r0Ry7hVnjZmkoU+QVkK+Kn2ZJLwqjRrTkulwDyTQ U= Received: (qmail 70062 invoked by alias); 24 Sep 2019 20:35:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 70047 invoked by uid 89); 24 Sep 2019 20:35:21 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-lj1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=54aJSX6rJwizKq5++2keY5WghGihlr5egeHhaihL5RE=; b=m6o6zjl7Hf05HdRpLUI9aNq/J1SFcrGcU5Z1CUfisK7Gb7EusVojdRDa2+Oexpe3G8 kOqVC0ERzH3PFrqcRTXX2n9QmERz5OM6dPtbA6afHZSae1j/pWzvEsRe118V3GA0zlQb z+6k2fLTNgSqHIb1HWjVM//Xc2LZknF1QtuQQE9nH9CbIRq7RmitYRmcpzIev5eFN0R6 nZLYwc2Nct8zbdPR+UA120VhwoFa5nHmEng84lqO2dsDIPJ/sCFMOl/4PTukQ5SSa1/F rn8PHog3RBmP2W2ZaTkHd6JhbP339to7ken9AdK2UgrfdK8rQLJViOlJtsSjYzuCWjCm Sytg== MIME-Version: 1.0 References: <20190916221536.18500-1-alistair.francis@wdc.com> <83b0d556-ef9d-adbf-85ac-d4ef8857f9b9@redhat.com> In-Reply-To: <83b0d556-ef9d-adbf-85ac-d4ef8857f9b9@redhat.com> From: Alistair Francis Date: Tue, 24 Sep 2019 13:30:35 -0700 Message-ID: Subject: Re: [PATCH] inet/net-internal.h: Fix uninitalised clntudp_call() variable To: "Carlos O'Donell" Cc: Alistair Francis , GNU C Library , Jeff Law , Joseph Myers , Zack Weinberg , "Maciej W. Rozycki" Content-Type: text/plain; charset="UTF-8" On Tue, Sep 24, 2019 at 1:21 PM Carlos O'Donell wrote: > > On 9/16/19 6:15 PM, Alistair Francis wrote: > > The total_deadline variable inside the clntudp_call() function inside > > sunrpc/clnt_udp.c can cause uninitalised variable warnings when building > > with GCC 8.3 or 9.2 on a platform with a 64-bit tv_nsec on a 32-bit > > architecture. To fix the warning let's use the DIAG_* macros to hide the > > warning. > > > > A GCC bug case has also been submitted: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91691 > > > > This looks good to me. If you're seeing this using the released 8.3 or 9.2 > then others will see it too. You also reference the compiler version that > is the latest with the problem e.g. 9. I don't think we should fix this > by zeroing out the entire field since this looks like an optimization > or compiler related issue. > > OK for master. Thanks! I don't have commit access yet, I'm going to start the process of requesting it. I named you as the person to approve my account creation Carlos. While that is happening if anyone else would like to apply this patch please feel free to :) Alistair > > Reviewed-by: Carlos O'Donell > > > 2019-09-16 Alistair Francis > > > > * inet/net-internal.h: Fix uninitalised clntudp_call() variable > > --- > > inet/net-internal.h | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/inet/net-internal.h b/inet/net-internal.h > > index 2f522eef555..c774de2b78a 100644 > > --- a/inet/net-internal.h > > +++ b/inet/net-internal.h > > @@ -23,6 +23,7 @@ > > #include > > #include > > #include > > +#include > > > > int __inet6_scopeid_pton (const struct in6_addr *address, > > const char *scope, uint32_t *result); > > @@ -96,6 +97,16 @@ __deadline_is_infinite (struct deadline deadline) > > return deadline.absolute.tv_nsec < 0; > > } > > > > +/* GCC 8.3 and 9.2 both incorrectly report total_deadline > > + * (from sunrpc/clnt_udp.c) as maybe-uninitialized when tv_sec is 8 bytes > > + * (64-bits) wide on 32-bit systems. We have to set -Wmaybe-uninitialized > > + * here as it won't fix the error in sunrpc/clnt_udp.c. > > + * A GCC bug has been filed here: > > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91691 > > + */ > > +DIAG_PUSH_NEEDS_COMMENT; > > +DIAG_IGNORE_NEEDS_COMMENT (9, "-Wmaybe-uninitialized"); > > + > > /* Return true if the current time is at the deadline or past it. */ > > static inline bool > > __deadline_elapsed (struct deadline_current_time current, > > @@ -120,6 +131,8 @@ __deadline_first (struct deadline left, struct deadline right) > > return right; > > } > > > > +DIAG_POP_NEEDS_COMMENT; > > + > > /* Add TV to the current time and return it. Returns a special > > infinite absolute deadline on overflow. */ > > struct deadline __deadline_from_timeval (struct deadline_current_time, > > > > > -- > Cheers, > Carlos.