From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1BE311F461 for ; Thu, 29 Aug 2019 17:34:35 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=ToBf fQZNi7JZ8E8sXugVUpSzpdephJcenXOx+Qa+ViQYLN4RCR0knvHVf8HvUGzrkIHy tvCKdClWkSJT/nY6rQxDA53yjhwY2tSvxTKf4dl9iNcHNHxv0dVwGzsXZKHnxsV4 iBMw6sRRf2/tMqVnOR4zGYUWNKdcPaOqo7LrlJs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=ebfMDgHfrt EGtj7YfVT/7R4q0Nc=; b=Jkxa0GHp/0OnoGaZb/yJxsHiPXfoDYhRg6cjPJTtZ+ bfiAB8h61STzmFj7PHUzzt4Vebp4jmaz1NA548gTwfZf9scSiiAvwfgOBFpsiYa6 BAfN9CVM1sPawoNBw8cRLdosMRLZynE968nA58ui2NkwdRrD+qeNYSS+wz/sGm9S k= Received: (qmail 22235 invoked by alias); 29 Aug 2019 17:34:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 22167 invoked by uid 89); 29 Aug 2019 17:34:26 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mailbackend.panix.com MIME-Version: 1.0 References: <871316fb87a99a59c31e6d3fbd4d35bff2ecc3c4.1567097252.git.alistair.francis@wdc.com> In-Reply-To: From: Zack Weinberg Date: Thu, 29 Aug 2019 13:34:09 -0400 Message-ID: Subject: Re: [RFC v5 01/21] sunrpc/clnt_udp: Ensure total_deadline is initalised To: Joseph Myers Cc: Alistair Francis , GNU C Library , Arnd Bergmann , Adhemerval Zanella , Florian Weimer , Palmer Dabbelt , macro@wdc.com, Zong Li , Alistair Francis Content-Type: text/plain; charset="UTF-8" On Thu, Aug 29, 2019 at 1:22 PM Joseph Myers wrote: > On Thu, 29 Aug 2019, Alistair Francis wrote: >The long pole is definitely the ml2014 build environment, unless for some reason we need the new version of pip first? I don't actually know. I'm assu > > Even though total_deadline won't be accessed uninitalised GCC can still > > complain that it is accessed unitalised, to avod those errors let's make > > sure we initalise it to 0. > > It's glibc practice (although missing from > ) that we *don't* > add initializations like that to avoid warnings. Although this has historically been glibc practice, I think it is unwisely incautious, and we should change the policy to be that we *do* add initializations whenever the compiler thinks a variable even _might_ be used uninitialized. zw