From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E77E91F461 for ; Tue, 3 Sep 2019 14:45:37 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=fpfP vsGqGOK2E9TmESeAmK/UuKpwYBWmkLMFEITpsF4iLSrwJSh0UAvLUPFMnUM0D2Ky 09xAD0BFr3GNFOwtthr9w1Qbunc71Jh2uqpA7voSHGVaW7hFk8Lsj1G4xZZgwGLC QfclyywVBed7xpyWoOPQqw9CkoRw5Ej349XPYso= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=FQMRc6C6Ej Xht5qE5papdCS+ejs=; b=UqYf+UXWxMJe5LlqjfYTppR029JMhJKaJpwAMpEKtP xHHu/+aFhCsAJbSb2N8TeLhx3ZCZm4qc/pHPYzM7xBWOrp3lyp8CItahaOmWZFnv cwu4korFKIFMoju/h9Af7lWqyW5B7Iq9gAan6ek4qETIjoiEcA9Q7STGxPQ8FqqZ A= Received: (qmail 49135 invoked by alias); 3 Sep 2019 14:45:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 48931 invoked by uid 89); 3 Sep 2019 14:45:15 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mailbackend.panix.com MIME-Version: 1.0 References: <20190828153236.18229-1-zackw@panix.com> <20190828153236.18229-5-zackw@panix.com> In-Reply-To: From: Zack Weinberg Date: Tue, 3 Sep 2019 10:44:52 -0400 Message-ID: Subject: Re: [PATCH v2 04/10] Use clock_settime to implement settimeofday. To: Adhemerval Zanella Cc: GNU C Library , Joseph Myers , Florian Weimer , Lukasz Majewski , Alistair Francis , Stepan Golosunov , Arnd Bergmann , Samuel Thibault Content-Type: text/plain; charset="UTF-8" On Mon, Sep 2, 2019 at 9:22 AM Adhemerval Zanella wrote: > > The vestigial "set time zone" feature of settimeofday complicates the > > generic settimeofday implementation a little. The only remaining uses > > of this feature that aren't just bugs, are using it to inform the > > Linux kernel of the offset between the hardware clock and UTC, on > > systems where the hardware clock doesn't run in UTC (usually because > > of dual-booting with Windows). There currently isn't any other way to > > do this. However, the callers that do this call settimeofday with > > _only_ the timezone argument non-NULL. Therefore, glibc's new > > behavior is: callers of settimeofday must supply one and only one of > > the two arguments. If both arguments are non-NULL, or both arguments > > are NULL, the call fails and sets errno to EINVAL. > > We definitely need a NEWS entry for this change. NEWS entries for the complete patchset are in the final patch of the series (with the manual changes). zw