From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 18A241F453 for ; Wed, 20 Feb 2019 13:05:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type :content-transfer-encoding; q=dns; s=default; b=RrQu6vVfOVjXs6la nVLFoHd4X+6Ka4KmUT7ZcLOepJtTkYrPcRMB6o6zj53U5H0BtE+06xCs/9Kgfj9t N7iaeVVmVL3m5PcHIxc5rg8F8jYa4dcmFF5iNcjcgqYggdHDGlCJbmx6GyThfmfp PCilvPE6nIC4wdR+sjO3hW+p+Yg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type :content-transfer-encoding; s=default; bh=0sfwhOTrjWAhnruBxdDUg2 6fSjo=; b=j16QapX4JgDoaN8tw3gqyV0lH8vST+E50pfaHV1bYQMCpbSsf+m1Jf PRJjAljc8H5jsf/fe7a2UZKXQajtAmKbm3C2F8/oUclCKgTeFUXaICPshWweYxCU pja5a6N6CdMMjdJsw2uiWU05mnvNORAQ2dnmMHjsYsZ8IigOPS1xg= Received: (qmail 123680 invoked by alias); 20 Feb 2019 13:05:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 123647 invoked by uid 89); 20 Feb 2019 13:05:46 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mailbackend.panix.com MIME-Version: 1.0 References: <863ffa3b-af66-7d82-21a8-e809fd6c1b62@suse.cz> <08214004-67b7-ce24-07ec-3cd685c65038@suse.cz> In-Reply-To: <08214004-67b7-ce24-07ec-3cd685c65038@suse.cz> From: Zack Weinberg Date: Wed, 20 Feb 2019 08:05:31 -0500 Message-ID: Subject: Re: [PATCH] Add new Fortran vector math header file. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Joseph Myers , GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 20, 2019 at 4:43 AM Martin Li=C5=A1ka wrote: > On 2/19/19 8:14 PM, Zack Weinberg wrote: > > My first reaction is to wonder whether math-vector-fortran.h should > > have an extension other than .h. I don't know what conventions there > > are for this sort of thing in Fortran, but if it could have some other > > extension then it would be easy to exclude it from this test in the > > makefiles. Another possibility is to put an Emacs-style "mode" > > annotation on the first line of the file: -*- f90 -*- which I could > > make my test program recognize and skip the file. > > Hi. > > I prefer to do the annotation instead of changing the file extension. > Can you please verify it's correct in the attached patch? Yes, these annotations are correct. You don't have to put them on a line by themselves, though, +! Platform-specific Fortran SIMD declarations of math functions. -*- f90 -= *- would also work. As long as I'm looking at this patch, I have two editorial notes: In both new files, "Platform-specific Fortran SIMD declarations of math functions" would be clearer with different word order: suggest "Platform-specific declarations of SIMD math functions for Fortran." In the generic file, "Get default empty builtin definitiones." has a typo ("definitiones" should be "definitions"), and having a sentence starting with "Get" on the last line of the file makes it look like there's something missing. Suggest instead "No SIMD math functions are available for this platform." zw