From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B451C1F4B4 for ; Wed, 7 Oct 2020 00:12:23 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BEA143857C66; Wed, 7 Oct 2020 00:12:21 +0000 (GMT) Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by sourceware.org (Postfix) with ESMTPS id 4AC613858D35 for ; Wed, 7 Oct 2020 00:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4AC613858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=panix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zackw@panix.com Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by mailbackend.panix.com (Postfix) with ESMTPSA id 4C5ZXM0Tfdz1cg6 for ; Tue, 6 Oct 2020 20:12:19 -0400 (EDT) Received: by mail-ed1-f42.google.com with SMTP id b12so278271edz.11 for ; Tue, 06 Oct 2020 17:12:19 -0700 (PDT) X-Gm-Message-State: AOAM533QNTzzH985KGCEWdyJDDTir4O681rDX/ipjqd0D0fMjG5Phww4 LtYdi6ysBPYXrlCw8wFXIEU31UC5YRi9hghxJNQ= X-Google-Smtp-Source: ABdhPJz76o42OHb+sAfbD8FbTS7rSaAm0bdYROBvyxEkaHEnwlCTYk3qq9hZ3XBPYxcn+x9wkLoZqMGEQ2WfF0d/NX4= X-Received: by 2002:a05:6402:1356:: with SMTP id y22mr696834edw.110.1602029538056; Tue, 06 Oct 2020 17:12:18 -0700 (PDT) MIME-Version: 1.0 References: <20201006054255.1676065-1-michaeljclark@mac.com> <20201006235648.1811725-1-michaeljclark@mac.com> In-Reply-To: <20201006235648.1811725-1-michaeljclark@mac.com> From: Zack Weinberg Date: Tue, 6 Oct 2020 20:12:06 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ldd: revise trace output for left-aligned relative addresses To: Michael Clark Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: GNU C Library Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Tue, Oct 6, 2020 at 7:57 PM Michael Clark via Libc-alpha wrote: > > This change updates ld.so trace for left-aligned relative addresses. > The primary goal of this change is to increase `ldd` readability by: > > - modifying trace output to use relative addresses by default. > - adding an alternative trace output mode with left-aligned addresses. I don't have an opinion on most of the patch, but I find the term "left-aligned addresses" very confusing -- in fact, on a first read I thought your patch did exactly the opposite of what it does. I'd describe the effect of LD_TRACE_ADDR_ALIGN=1 as "move load addresses from the end of the line to the beginning, and pad them with leading zeroes to a fixed width." Possibly the environment variable should be renamed to match. zw