From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6D6D620248 for ; Wed, 27 Feb 2019 15:01:31 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type :content-transfer-encoding; q=dns; s=default; b=qZQiD/vgD911/GlO Ebe9ELnkd0FywnZvQ+Pm0MnLG+1zKUXl0mMokhgAV0h4oOnUHwtAhfqOsdtvlIv7 MV0nRLsz4mQDY6OWFCuGjLhGgxFXwGAFMLgUs6a9UXGkTEP5yTkzpDmYGr7pLoZC 9yygipZZfLrO1Nm0tib0IjfWRGs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type :content-transfer-encoding; s=default; bh=WIBFb9THeI08W2+cn4YXFC jZpRo=; b=tWKlCiLOFDdCW1VlKGU47j7v9/sRc1XA5K9CTxcd+6H4zIRDFHR9lm Xg6YcBRrX0RjfYVg3HYRQM96IWP9DSf6eMiR+3On03iS3b6I7cEPQSAHrnWgt3WD erAsKBXhi2v1GvpC1nwaPU9pZOz/R9HUcgxOjibh1ehNaEQJnLXSA= Received: (qmail 78700 invoked by alias); 27 Feb 2019 15:01:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 78100 invoked by uid 89); 27 Feb 2019 15:01:16 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mailbackend.panix.com MIME-Version: 1.0 References: <863ffa3b-af66-7d82-21a8-e809fd6c1b62@suse.cz> <08214004-67b7-ce24-07ec-3cd685c65038@suse.cz> <84b2b212-a70a-e18a-5929-d89d6014fb70@suse.cz> <44cd0edb-2ab3-2908-8adb-f2e06859ecfe@suse.cz> <57bb8e48-8805-91ca-9902-9c6fbc3d5360@suse.cz> <87imx62qtr.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: Zack Weinberg Date: Wed, 27 Feb 2019 10:00:57 -0500 Message-ID: Subject: Re: [PATCH] Fix location where math-vector-fortran.h is installed. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Florian Weimer , Joseph Myers , GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 27, 2019 at 3:09 AM Martin Li=C5=A1ka wrote: > On 2/26/19 10:41 PM, Zack Weinberg wrote: > > On Tue, Feb 26, 2019 at 4:16 PM Florian Weimer wro= te: > >> * Martin Li=C5=A1ka: > >>> On 2/26/19 7:05 PM, Joseph Myers wrote: > >>>> On Tue, 26 Feb 2019, Martin Li=C5=A1ka wrote: > >>>> > >>>>> Hi. > >>>>> > >>>>> This is follow up patch where I fix location where the header > >>>>> is installed. I made a type as I was copying & pasting. > > > > Do I understand correctly that the desired installation location is > > $(prefix)/include/finclude/math-vector-fortran.h ? > > Yes. Will there ever be C headers in $(prefix)/include/finclude ? > >> In file included from /tmp/cih_test_C67G81.c:8: > >> ../sysdeps/x86/fpu/finclude/math-vector-fortran.h:1:1: error: expected= identifie > >> r or =E2=80=98(=E2=80=99 before =E2=80=98!=E2=80=99 token > >> ! Platform-specific declarations of SIMD math functions for Fortran. = -*- f90 -* > > I skipped that header explicitly. ... > + # Skip Fortran header > + (finclude/math-vector-fortran.h) > + continue;; To put the above question another way, is there a reason why this shouldn't= be + # Skip Fortran headers + (finclude/*) + continue;; ? > And for the check-wrapper-headers.py, I read a header file and skip files > with 'f90' file type. If you're going to do it this way, I recommend you copy the more general Emacs modeline parser from https://sourceware.org/ml/libc-alpha/2019-02/msg00539.html ... but if we can just skip finclude/* that might be a better approach for both scripts. zw