From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5F83A1F453 for ; Tue, 19 Feb 2019 19:15:35 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=M+ek Puv7ZBJ83vQMaeV0TmzZgUHLFHnUjr9cLbMp6vArpFu8L/SiP/kbVVy+1J3JZzO6 ELWelUfTHm6V/0PNMAepHVXSEOKW+sOaSUC3KNVEwOz8wocOvGMzks8P6Oktmgnw SaqDVzxkMDRBfvY3AahmGb1n565+c4eQf3KZed8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=G78O+42w1s PENEQ66EwpfDRUEM8=; b=GkR7lHl+TwiiuPKhCt36LG1E5N88uuoVxAgVvJuNQw WszjY1RwjhrD92n31pXGmU+z2lG2UuJtp/jxdLcqfbydvfGYKIAjCaYO94AcNVtc pInq0FYL0soNIQF/TbrKzaOoQT0a+PxTS+0hfVXyOx0fLryKI1pg90D84wl/+9DH s= Received: (qmail 7351 invoked by alias); 19 Feb 2019 19:14:48 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 7243 invoked by uid 89); 19 Feb 2019 19:14:47 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mailbackend.panix.com MIME-Version: 1.0 References: <863ffa3b-af66-7d82-21a8-e809fd6c1b62@suse.cz> In-Reply-To: From: Zack Weinberg Date: Tue, 19 Feb 2019 14:14:31 -0500 Message-ID: Subject: Re: [PATCH] Add new Fortran vector math header file. To: Joseph Myers Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , GNU C Library Content-Type: text/plain; charset="UTF-8" On Tue, Feb 19, 2019 at 12:59 PM Joseph Myers wrote: > *But* there could be potential interactions with Zack's patch > to tokenize > installed headers to check for obsolete typedefs, since that of course is > tokenizing headers as C and this is adding a Fortran header to the > installed headers. Good catch, I hadn't been paying attention to this discussion. The proposed math-vector-fortran.h is indeed a problem for the test program in my patch, because of the use of $, which is not part of the C basic source character set. (If I remember correctly, GCC allows $ in identifiers as an extension to C, but my test program is intentionally very picky.) My first reaction is to wonder whether math-vector-fortran.h should have an extension other than .h. I don't know what conventions there are for this sort of thing in Fortran, but if it could have some other extension then it would be easy to exclude it from this test in the makefiles. Another possibility is to put an Emacs-style "mode" annotation on the first line of the file: -*- f90 -*- which I could make my test program recognize and skip the file. Incidentally, this looks like a copy-and-paste error: +! You should have received a copy of the GNU Lesser General Public +! License along with the GNU C Library; if not, see +! . */ Should that last line have a */ on it? zw