unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Zack Weinberg <zackw@panix.com>
To: GNU C Library <libc-alpha@sourceware.org>
Cc: "Carlos O'Donell" <carlos@redhat.com>,
	Florian Weimer <fweimer@redhat.com>, DJ Delorie <dj@redhat.com>,
	 Arjun Shankar <arjun@redhat.com>
Subject: Re: [PATCH] Use a proper C tokenizer to implement the obsolete typedefs test.
Date: Tue, 12 Feb 2019 10:29:11 -0500	[thread overview]
Message-ID: <CAKCAbMgJdZ6JzQHDFfZ_8NYJ-zTTot4wNfpvCeyLSFnDmtL=Ow@mail.gmail.com> (raw)
In-Reply-To: <20190119164627.14259-1-zackw@panix.com>

On Sat, Jan 19, 2019 at 11:46 AM Zack Weinberg <zackw@panix.com> wrote:
>
> The test for obsolete typedefs in installed headers was implemented
> using “grep” and could therefore get false positives on e.g. “ulong”
> in a comment.  It was also scanning all of the headers included by our
> headers, and therefore testing headers we don’t control, e.g. Linux
> kernel headers.
>
> This patch splits the obsolete-typedef test from
> scripts/check-installed-headers.sh to a separate program,
> scripts/check-obsolete-constructs.py.  Being implemented in Python,
> it is feasible to make it tokenize C accurately enough to avoid false
> positives on the contents of comments and strings.  It also only
> examines $(headers) in each subdirectory--all the headers we install,
> but not any external dependencies of those headers.

Ping?

zw

      parent reply	other threads:[~2019-02-12 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19 16:46 [PATCH] Use a proper C tokenizer to implement the obsolete typedefs test Zack Weinberg
2019-01-21 18:22 ` Joseph Myers
2019-02-12 15:29 ` Zack Weinberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKCAbMgJdZ6JzQHDFfZ_8NYJ-zTTot4wNfpvCeyLSFnDmtL=Ow@mail.gmail.com' \
    --to=zackw@panix.com \
    --cc=arjun@redhat.com \
    --cc=carlos@redhat.com \
    --cc=dj@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).