From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-0.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8DE2D200B9 for ; Mon, 7 May 2018 02:49:31 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=tezS 17DD74p7H5WYUKOwcy0Cn4oBxS7dMPEEHuJfZSxp/3i0E2pIMM/rXLIOIV8aQxdp sUVAK+GezUNDu2lducFIuIg6t4E7F04t9oxOOnHyDoFJ4mo1gnFND7nqbTh4v4ob VZwF79kT/9zqltvJeZXUQ9k4GlraQqd6eajOZxA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; s=default; bh=06xiXw99f1 XqNeuJuPKBD1tP3D8=; b=Db3znvaa+VQrPQD7J7UKOIuamxACRTLIQPxjEQ4Okg i7b7zVEr3Z3UZ8zXvWyLliPImhpXNHXbfJpheuOE8gduv9IK8n/BEf0aDZ+BW4P7 okrvO8oC3F6qrY7VMahD9q+C52mn/lRREwpBV3RDPBMJrqSJsE7maT4Jcz6j+nlL c= Received: (qmail 49816 invoked by alias); 7 May 2018 02:49:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 49551 invoked by uid 89); 7 May 2018 02:48:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mailbackend.panix.com X-Gm-Message-State: ALQs6tA5q6tWsDaxTGyGfyzO71iw3+CbJ59LD2Ct2DutKx2C9VeJrpSs gb26HkgqgTDrTSJs5EX6ho63y4QPEcC2B5RokCA= X-Google-Smtp-Source: AB8JxZrsX9uTl4r4Xl+opTGvi8933yJzAwHzbHFVABg5cr3X/wNwv77nAfC7Kh+r2MG8WEvCgH+hfeFxD69IWiNu6Rs= X-Received: by 2002:aca:6986:: with SMTP id e128-v6mr21473052oic.181.1525661285294; Sun, 06 May 2018 19:48:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4141f1f5-c4b2-f94c-6fe2-b961f5e3ee8a@linaro.org> References: <1519679016-12241-1-git-send-email-adhemerval.zanella@linaro.org> <1519679016-12241-4-git-send-email-adhemerval.zanella@linaro.org> <4141f1f5-c4b2-f94c-6fe2-b961f5e3ee8a@linaro.org> From: Zack Weinberg Date: Sun, 6 May 2018 22:48:04 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 03/21] nptl: Fix Race conditions in pthread cancellation (BZ#12683) To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" On Fri, Apr 27, 2018 at 8:25 AM, Adhemerval Zanella wrote: > On 27/04/2018 09:20, Zack Weinberg wrote: >> On Mon, Feb 26, 2018 at 4:03 PM, Adhemerval Zanella >> wrote: >>> This patches fixes some race conditions in NPTL cancellation code by >>> redefining how cancellable syscalls are defined and handled. Current >>> approach is to enable asynchronous cancellation prior to making the syscall >>> and restore the previous cancellation type once the syscall returns. >> >> Did these patches ever get reviewed/committed? #12683 has been >> festering for a long time... > > Thanks for bring this up. No, I haven't received any review so far about it. Let's try to unjam this. I will post reviews for patches 1, 2, 3, 4, and 6 shortly. Unfortunately, all of the other patches require review by architecture experts; I don't know enough about the low-level ABI details for anything other than plain x86-32 and -64. zw