unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Alistair Francis <alistair23@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
	Alistair Francis <alistair.francis@wdc.com>,
	 Lukasz Majewski <lukma@denx.de>
Subject: Re: 32-bit time_t inside itimerval
Date: Mon, 30 Dec 2019 21:11:14 +0100	[thread overview]
Message-ID: <CAK8P3a3t9c0248OFnSHD-dwH7kZTv6nrCum-kszULdP4Eqbd0g@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKODSj2dNGTTKnkM-QSwL2CWMYpRTPJhVmiotcFjt4q7Qg@mail.gmail.com>

On Mon, Dec 30, 2019 at 8:57 PM Alistair Francis <alistair23@gmail.com> wrote:
> On Mon, Dec 30, 2019 at 2:02 AM Arnd Bergmann <arnd@arndb.de> wrote:
> > On Sat, Dec 21, 2019 at 6:19 PM Alistair Francis <alistair23@gmail.com> wrote:
> > > For the glibc people, can we do something like this?
> > >
> > >  1. Add a __old_timeval struct used by the itimerval and rusage structs
> > >  2. Make __old_timeval use __old_time_t that is always a long (no
> > > matter what time_t really is)
> >
> > If you have linux-5.1 kernel headers, there is already __kernel_old_timeval
> > that is defined specifically for this purpose. Not sure if you can use those
> > given the state of the kernel headers overall.
> >
> > > Then the question becomes do we expose __old_timeval (with 32-bit
> > > time_t) or the real timeval (64-bit time_t) to callers of the
> > > functions?
> >
> > I would think this has to be the actual timeval, there is no point in
> > changing the API now.
>
> Yeah, agreed. I have updated the RV32 port to internally convert
> between 32/64-bit.

Any chance of making this the default implementation for 32-bit
rather than RV32 specific? The code should be the same for any
time64 user space regardless of the architecture.

       Arnd

  reply	other threads:[~2019-12-30 20:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20 22:28 32-bit time_t inside itimerval Alistair Francis
2019-12-21 13:31 ` Arnd Bergmann
2019-12-21 17:18   ` Alistair Francis
2019-12-30 10:02     ` Arnd Bergmann
2019-12-30 19:51       ` Alistair Francis
2019-12-30 20:11         ` Arnd Bergmann [this message]
2019-12-30 21:16           ` Alistair Francis
2019-12-30 22:11             ` Arnd Bergmann
2020-01-02 12:08               ` Lukasz Majewski
2020-01-02 12:28                 ` Arnd Bergmann
2020-01-04 18:03                   ` Alistair Francis
2020-01-05 16:07                     ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3t9c0248OFnSHD-dwH7kZTv6nrCum-kszULdP4Eqbd0g@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=alistair.francis@wdc.com \
    --cc=alistair23@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).