unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Lukasz Majewski <lukma@denx.de>,
	Joseph Myers <joseph@codesourcery.com>,
	 Paul Eggert <eggert@cs.ucla.edu>,
	Andreas Schwab <schwab@suse.de>,
	 Alistair Francis <alistair23@gmail.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	 GNU C Library <libc-alpha@sourceware.org>,
	Siddhesh Poyarekar <siddhesh@gotplt.org>,
	 Florian Weimer <fweimer@redhat.com>,
	Florian Weimer <fw@deneb.enyo.de>,
	Zack Weinberg <zackw@panix.com>,
	 "Carlos O'Donell" <carlos@redhat.com>
Subject: Re: [PATCH v4 1/2] y2038: linux: Provide __timerfd_gettime64 implementation
Date: Tue, 7 Jan 2020 21:22:52 +0100	[thread overview]
Message-ID: <CAK8P3a2W0oGHWT7GETMg99-csz1LK1h19L52ShiLNfR8E3dqOw@mail.gmail.com> (raw)
In-Reply-To: <a4198224-902a-9955-1d5f-92765ba0abae@linaro.org>

On Tue, Jan 7, 2020 at 9:16 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> On 07/01/2020 11:25, Lukasz Majewski wrote:
> >> On 07/01/2020 06:27, Lukasz Majewski wrote:
> >>
> >>>> As a side note, now that arch-syscall patch is upstream should we
> >>>> assume that for !__ASSUME_TIME64_SYSCALLS the
> >>>> __NR_timerfd_gettime64 should be defined (meaning that Linux
> >>>> supports time64 for all 32-bit architectures)?
> >>>
> >>> Only Linux version >= 5.1 supports 64 bit time on archs with
> >>> __WORDSIZE = 32. I do guess (but I may be wrong here) that the
> >>> arch-syscall is supposed to reflect the exact syscalls provided by
> >>> kernel headers used for building (to help with validation of Y2038
> >>> patches).
> >>
> >> The arch-syscall is now autogenerated from the latest kernel release
> >> defined in build-many-glibcs.py. So the question is whether Linux
> >> support and enforces time64 support on all and future 32-bit
> >> architectures or if there is still some missing ones (as it has
> >> happen on some syscall additions, where some architecture lag
> >> behind some releases).
> >
> > This question would be best answered by Arnd (CC'ed) IMHO. From what I
> > know all 32 bit architectures gained syscalls covered by
> > __ASSUME_TIME64_SYSCALLS from Linux 5.1+.
> >
> > The arch-syscall seems to me like a mean to test for example the time
> > related syscalls which use different versions (32bit time vs 64 bit) on
> > different archs. Notable example - clock_gettime(). Am I right?
>
> The arch-syscall is a way to decouple the build from the kernel header
> used on build, which might simplify the logic to use some kernel
> features.
>
> On the clock_gettime, for instance, as Arnd has indicated we can
> assume that __NR_clock_gettime64 will be always presented for
> !__ASSUME_TIME64_SYSCALLS.
>
> It would be interesting if kernel also could enforce that new
> generic syscalls would be wire-up, or at least the syscall number
> reserved; once a new generic syscall is introduced.  It would
> simplify the __ASSUME_* macro, not requiring the arch-specific
> overrides on some architectures.

We currently try to enforce it through review since the introduction
of the automatically generated asm/unistd.h header files, but his
has already failed one time for the recent clone3 system call that
accidentally was missing on one architecture.

I have some plans to enforce it using tooling, but it should
at least be a safe assumption that all new system calls have
the same numbers across all architectures and are added at
the same time.

I also have some vague plans to automatically generate not
only the asm/unistd.h header but also some trivial wrappers
around syscall() that provide an inline function with the correct
arguments, to allow calling any syscall without relying on libc
to provide a wrapper for it.

          Arnd

  reply	other threads:[~2020-01-07 20:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 12:17 [PATCH v4 1/2] y2038: linux: Provide __timerfd_gettime64 implementation Lukasz Majewski
2020-01-06 12:17 ` [PATCH v4 2/2] y2038: linux: Provide __timerfd_settime64 implementation Lukasz Majewski
2020-01-06 21:06   ` Adhemerval Zanella
2020-01-06 20:34 ` [PATCH v4 1/2] y2038: linux: Provide __timerfd_gettime64 implementation Adhemerval Zanella
2020-01-07  9:27   ` Lukasz Majewski
2020-01-07 12:36     ` Adhemerval Zanella
2020-01-07 14:25       ` Lukasz Majewski
2020-01-07 15:26         ` Arnd Bergmann
2020-01-07 20:16         ` Adhemerval Zanella
2020-01-07 20:22           ` Arnd Bergmann [this message]
2020-01-07 23:06           ` Lukasz Majewski
2020-01-07 12:49     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a2W0oGHWT7GETMg99-csz1LK1h19L52ShiLNfR8E3dqOw@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=adhemerval.zanella@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=alistair23@gmail.com \
    --cc=carlos@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=fw@deneb.enyo.de \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    --cc=schwab@suse.de \
    --cc=siddhesh@gotplt.org \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).