From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3199C1F45E for ; Wed, 12 Feb 2020 12:58:37 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=uTAo 6gumYJ+3AogfOaR7433qp/et+Xu6uPCLBQGnqUJ/aeJ1YQ80AY1EqE22xNkJEV34 31p8HNjLzloo9VI25uCnk+5TtEzAOyF3c1IGpZSuJGisOLfNHPAjvb4bTHY5/ViI iQWVhts/jB/xRAuNHh4OxQZf3THSPdt91fmcFp4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=p9XyIbaGZj J40XpnkZr+O4l3fLg=; b=sio83Np9cAnXOwx+T2P4s6zp7JGAohmDmIKcN66KpU QKJyG/3YJgXFB5TzqEbWvcctOolvPhJx+WJiErwnDIEeWRrVn/pxcDS+CjJk4LBg wujtCkT/xMu4yAhu+KjBo/pS2VXfpTz9mdBno3ymtEib+SsUrW8tYHlibRWxQ7cl 0= Received: (qmail 116799 invoked by alias); 12 Feb 2020 12:58:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 116791 invoked by uid 89); 12 Feb 2020 12:58:34 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mout.kundenserver.de MIME-Version: 1.0 References: <4e95f95966d8d7c6a8339160dc62d81c1f6a1bfb.1578824547.git.alistair.francis@wdc.com> <00574bfb-981a-3a1c-cbdf-b2fee4eddc32@gmail.com> <3ca7e2cb-55c2-1118-90b8-505586b36ee7@gmail.com> In-Reply-To: <3ca7e2cb-55c2-1118-90b8-505586b36ee7@gmail.com> From: Arnd Bergmann Date: Wed, 12 Feb 2020 13:58:12 +0100 Message-ID: Subject: Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 To: Vineet Gupta Cc: Alistair Francis , Florian Weimer , GNU C Library , Palmer Dabbelt , Zong Li , Alistair Francis , Adhemerval Zanella , "Maciej W. Rozycki" , arcml , Joseph Myers Content-Type: text/plain; charset="UTF-8" On Wed, Feb 12, 2020 at 2:42 AM Vineet Gupta wrote: > On 2/11/20 4:14 PM, Alistair Francis wrote: > > On Tue, Feb 11, 2020 at 4:14 PM Vineet Gupta wrote: > > >>> +/* Same for ino_t and ino64_t. */ > >>> +# define __INO_T_MATCHES_INO64_T 1 > > I'm surprised that ARC port doesn't define this in glibc, yet we use the > asm-generic syscall interface where this is true. I need to investigate more. All 32-bit kernels supported by glibc today define the 64-bit file offset types (__off64_t, __ino64_t, ...) and a lot of them never had the old 'long' types (__off_t, __ino_t, ...), but applications can still pick between the two ABIs when compiling against glibc, see /usr/include/fcntl.h: #ifndef __off_t_defined # ifndef __USE_FILE_OFFSET64 typedef __off_t off_t; # else typedef __off64_t off_t; # endif # define __off_t_defined #endif If you use the old types, glibc will do the conversion in the syscall wrappers on architectures that only have the 64-bit interfaces. Arnd