From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Benchtests: Improve large memcpy/memset benchmarks
Date: Thu, 28 Mar 2024 14:28:41 -0500 [thread overview]
Message-ID: <CAFUsyfLYyYvO6OUTBGuqHNW48gvoXOxQE109XZQJ3g9v677kfQ@mail.gmail.com> (raw)
In-Reply-To: <PAWPR08MB898209811A71E973E96C591B83342@PAWPR08MB8982.eurprd08.prod.outlook.com>
On Wed, Mar 27, 2024 at 12:02 PM Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>
> Hi Noah,
>
> > > @@ -33,7 +31,7 @@ static void
> > > do_one_test (json_ctx_t *json_ctx, impl_t *impl, char *dst, char *src,
> > > size_t len)
> > > {
> > > - size_t i, iters = 16;
> > > + size_t i, iters = (MIN_PAGE_SIZE * 8) / len;
> > maybe MAX(16, (MIN_PAGE_SIZE * )/ len). Likewise above.
>
> I'm not sure how that helps - the issue was that 16 iterations was not only
> too small for smaller sizes but also too large for large sizes. This uses 8
> iterations for the largest sizes (which takes ~7 seconds on an older machine).
I see, didn't realize 16 was too high.
Although do think we should ensure at least 1 iter.
>
> > Also, can you include the iter count in the output?
>
> The time it prints is already divided by iterations, so it's not directly usable.
>
> A better option for these benchmarks would be to print the bandwidth.
iter count allows us to better estimate the variance.
>
> Cheers,
> Wilco
next prev parent reply other threads:[~2024-03-28 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 15:08 [PATCH] Benchtests: Improve large memcpy/memset benchmarks Wilco Dijkstra
2024-03-18 19:29 ` Noah Goldstein
2024-03-18 19:34 ` Noah Goldstein
2024-03-27 17:02 ` Wilco Dijkstra
2024-03-28 19:28 ` Noah Goldstein [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-23 11:41 Wilco Dijkstra via Libc-alpha
2023-03-23 18:17 ` Noah Goldstein via Libc-alpha
2023-03-23 23:01 ` Wilco Dijkstra via Libc-alpha
2023-03-24 16:29 ` Noah Goldstein via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFUsyfLYyYvO6OUTBGuqHNW48gvoXOxQE109XZQJ3g9v677kfQ@mail.gmail.com \
--to=goldstein.w.n@gmail.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).