From: "Fāng-ruì Sòng via Libc-alpha" <libc-alpha@sourceware.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Delete obsoleted DISTINGUISH_LIB_VERSIONS
Date: Mon, 16 Aug 2021 10:03:32 -0700 [thread overview]
Message-ID: <CAFP8O3L_KYgKFukyrZ+Zv8rLQtSwX285bhRYUTQH+jiGF6wJHg@mail.gmail.com> (raw)
In-Reply-To: <20210807051211.1018349-1-maskray@google.com>
Ping
On Fri, Aug 6, 2021 at 10:12 PM Fangrui Song <maskray@google.com> wrote:
>
> and its only definition in i386/dl-librecon.h which essentially
> hasn't been updated since 2004.
> ---
> elf/rtld.c | 4 ----
> sysdeps/unix/sysv/linux/i386/dl-librecon.h | 25 ----------------------
> 2 files changed, 29 deletions(-)
>
> diff --git a/elf/rtld.c b/elf/rtld.c
> index d733359eaf..4196bae703 100644
> --- a/elf/rtld.c
> +++ b/elf/rtld.c
> @@ -1637,10 +1637,6 @@ dl_main (const ElfW(Phdr) *phdr,
> if (main_map->l_ld == NULL)
> _exit (1);
>
> - /* We allow here some platform specific code. */
> -#ifdef DISTINGUISH_LIB_VERSIONS
> - DISTINGUISH_LIB_VERSIONS;
> -#endif
> _exit (has_interp ? 0 : 2);
> }
>
> diff --git a/sysdeps/unix/sysv/linux/i386/dl-librecon.h b/sysdeps/unix/sysv/linux/i386/dl-librecon.h
> index 7efe0679b3..e4d90529b8 100644
> --- a/sysdeps/unix/sysv/linux/i386/dl-librecon.h
> +++ b/sysdeps/unix/sysv/linux/i386/dl-librecon.h
> @@ -21,31 +21,6 @@
>
> #include <sysdeps/unix/sysv/linux/dl-librecon.h>
>
> -#define DISTINGUISH_LIB_VERSIONS \
> - do \
> - { \
> - /* We have to find out whether the binary is linked against \
> - libc 5 or glibc. We do this by looking at all the DT_NEEDED \
> - entries. If one is libc.so.5 this is a libc 5 linked binary. */ \
> - if (main_map->l_info[DT_NEEDED]) \
> - { \
> - /* We have dependencies. */ \
> - const ElfW(Dyn) *d; \
> - const char *strtab; \
> - \
> - strtab = (const char *) D_PTR (main_map, l_info[DT_STRTAB]); \
> - \
> - for (d = main_map->l_ld; d->d_tag != DT_NULL; ++d) \
> - if (d->d_tag == DT_NEEDED \
> - && strcmp (strtab + d->d_un.d_val, "libc.so.5") == 0) \
> - break; \
> - \
> - /* We print a `5' or `6' depending on the outcome. */ \
> - _dl_printf (d->d_tag != DT_NULL ? "5\n" : "6\n"); \
> - } \
> - } \
> - while (0)
> -
> /* Recognizing extra environment variables. */
> #define EXTRA_LD_ENVVARS \
> case 15: \
> --
> 2.32.0.605.g8dce9f2422-goog
>
--
宋方睿
next prev parent reply other threads:[~2021-08-16 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 5:12 [PATCH] elf: Delete obsoleted DISTINGUISH_LIB_VERSIONS Fangrui Song via Libc-alpha
2021-08-16 17:03 ` Fāng-ruì Sòng via Libc-alpha [this message]
2021-08-16 17:13 ` Florian Weimer via Libc-alpha
2021-08-16 17:36 ` Fāng-ruì Sòng via Libc-alpha
2021-08-17 7:51 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFP8O3L_KYgKFukyrZ+Zv8rLQtSwX285bhRYUTQH+jiGF6wJHg@mail.gmail.com \
--to=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).