From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C57DA1F8C8 for ; Mon, 20 Sep 2021 17:55:45 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D613C385841A for ; Mon, 20 Sep 2021 17:55:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D613C385841A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632160543; bh=tlR5tRf7pKM0n45a5h9ohZUYwIr7VmzjTFRccMuvjQs=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KCwGpZiSG0FGLlFSiM0kIjyLSeRgxp6O6OW5is3JD8TkcOFnvMsrZ8AMCv8MS0g9t WQRpuEfgPFhEQf2O16+ssBEIFT31jYg9ckeLuAH8PTHNF07FBfHmvSqh+KzCGITD0v g6qV6X9gbvB5B3E182WA5xq4aAbXuPAsSjFw2WSg= Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id 102D3385840E for ; Mon, 20 Sep 2021 17:55:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 102D3385840E Received: by mail-qk1-x731.google.com with SMTP id f130so6162641qke.6 for ; Mon, 20 Sep 2021 10:55:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tlR5tRf7pKM0n45a5h9ohZUYwIr7VmzjTFRccMuvjQs=; b=vKLy3Hv7e+LBcrDZUlalRuCkqf0Vg7fcbuv6RmHkEBVA50hk81WHl8FcDg0WF6tHPr Fi9gHyujQVhqoMzCtO77y9S2TBsoC76L66nEGq1E3HorAGPMl4rcQq7CMZW+0FEVXf69 BihtpAfky7bRxz5Fu/mVL8ECZiJzDcc+Ep7hDwNoxRku4YaW/qYjHPNH+atmuD7lDb6n WM5Dfnoq5/jLutugtnzWFloCCD4yYESpy/L7ZOTVABkUCApz0hGQIi8p6K33NBcti4i/ B8WdaIWAPaeuJbOtfW3g4rRBjwOVZq8tcN7nQIP+bCTsyeCuTYJI1gp88KBXeztOnXR4 YbdA== X-Gm-Message-State: AOAM532DS6ovJAWiu1gNiKyD9/Ajjg/mINdlY9r/0eMRMo6b/6fbY3+8 H13k3D6qZ7uRbIeHjTzPY/+DYL+9kXk2P1Sz1cxnpQ== X-Google-Smtp-Source: ABdhPJzZyGACsvs68yho6zqbt5PQ36kKqZCai/Sirk71zRUz/6qatLL+AOOV6mK+RVrdmdbKMJ6jFYK8ovMHeoW5uUw= X-Received: by 2002:a25:ba08:: with SMTP id t8mr34347422ybg.111.1632160519919; Mon, 20 Sep 2021 10:55:19 -0700 (PDT) MIME-Version: 1.0 References: <20210823043648.2648608-1-maskray@google.com> <87tuj255se.fsf@oldenburg.str.redhat.com> <20210904035235.giercjqdwzjukxb5@google.com> In-Reply-To: Date: Mon, 20 Sep 2021 10:55:08 -0700 Message-ID: Subject: PING^2: [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220] To: Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?F=C4=81ng-ru=C3=AC_S=C3=B2ng_via_Libc-alpha?= Reply-To: =?UTF-8?B?RsSBbmctcnXDrCBTw7JuZw==?= Cc: Fangrui Song via Libc-alpha Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" ping On Mon, Sep 13, 2021 at 9:36 AM F=C4=81ng-ru=C3=AC S=C3=B2ng wrote: > > ping > > On Fri, Sep 3, 2021 at 8:52 PM Fangrui Song wrote: > > > > On 2021-09-03, Florian Weimer wrote: > > >* Fangrui Song via Libc-alpha: > > > > > >> [Alternative to https://sourceware.org/pipermail/libc-alpha/2021-Aug= ust/130340.html > > >> This version fixes all ports and doesn't add NESTING dispatches.] > > >> > > >> dynamic-link.h is included more than once in some elf/ files (rtld.c= , > > >> dl-conflict.c, dl-reloc.c, dl-reloc-static-pie.c) and uses GCC neste= d > > >> functions. This harms readability and the nested functions usage > > >> is the biggest obstacle prevents CC=3Dclang (which doesn't support t= he > > >> feature). > > > > > >This patch causes elf/tst-nodelete to fail on x86_64, powerpc64, > > >powerpc64le at least: > > > > > >| Unique symbols test failed > > > > > >I assume something is wrong with the initialization of the new global > > >variables. > > > > I unintentionally missed DL_LOOKUP_FOR_RELOCATE > > (fcb04b9aed26a737159ef7be9c5a6ad0994437dc ("Introduce > > DL_LOOKUP_FOR_RELOCATE flag for _dl_lookup_symbol_x")) when rebasing th= e > > multi-line macro RESOLVE_MAP. > > > > Fixed in > > https://sourceware.org/git/?p=3Dglibc.git;a=3Dshortlog;h=3Drefs/heads/m= askray/unnest > > > > (Sorry about my negligence. On my Debian, master has 14 FAIL, and I > > probably missed that tst-nodelete additionally failed.) --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF