From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D22201F45E for ; Thu, 20 Feb 2020 15:12:35 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type :content-transfer-encoding; q=dns; s=default; b=qlfYlK8Ns7AVMu+n iJcQ1X4Gl+IND7uN16KcFP5IpTquyToQwCugGeBZfXWaNQ/aNGcGZpcqTL0CEAyY wXOOCqXgzLboQd92feFWi2uUMaCjw82WciYm587sf7puZyFm3U1ivUBKmypYH5p9 VKPe1wBA+GxvTqfbfZCkLtvYzQ0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type :content-transfer-encoding; s=default; bh=mET05vdzgyL4s1h13G9L9Q VZMyY=; b=qZKFie0G6/moyIOXxMK06h6a3ulwCyzo+iic8Uy2r5++wMAvNRXAgB j06U+ClNAmVS3WzkKBQ7RqxsKgvgN523XyRWcB/1fbZoQVvNETBEsubXRGVLgL/m 5giOHZd5uNqwbxgpS8Kry9psMhjXkJsPWpnMzqnZQlCpoiV6NYUw0= Received: (qmail 96204 invoked by alias); 20 Feb 2020 15:12:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 96190 invoked by uid 89); 20 Feb 2020 15:12:33 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582211549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oFqeW74D91oXE0Eu822vcbnX1LoXYTyHTIuImucoOoQ=; b=HFAbpt4odMKJ9NBp5j5YIryXouJu5ydsFUszB+gfxo68N/GSzSKInsRcwYw98dgbAvbmA/ cfkilne38ZtIkvcEap6K/BssSLgSj8oCf9kbkHKAsE0aO1ZtXWxrC59Rv1tYzWNfe2qyao WlxM2lAADdYvAWDaNcVgWXrjUwNXmfA= MIME-Version: 1.0 References: <20200220143406.4768-1-adhemerval.zanella@linaro.org> <878skxfgfd.fsf@oldenburg2.str.redhat.com> In-Reply-To: <878skxfgfd.fsf@oldenburg2.str.redhat.com> From: "Carlos O'Donell" Date: Thu, 20 Feb 2020 10:12:15 -0500 Message-ID: Subject: Re: [PATCH] support: Kill process group for test failure To: Florian Weimer Cc: Adhemerval Zanella , GNU C Library X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 20, 2020 at 10:05 AM Florian Weimer wrote: > > * Adhemerval Zanella: > > > Some testcases that create multiple subprocesses might abort or exit > > prior waiting for their children. In such case, support_test_main > > does not try to kill the spawned test process group (as in the > > test timeout case). > > Does this actually work? Is the process group preserved if a process is > reparented to init? No, you are right. There is a race too which I didn't see. Once you waitpid the pid and pgid might be free for reuse and we can't guarantee this will work. Cheers, Carlos.