unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Jordan Abrahams via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
	Jann Horn <jannh@google.com>,
	Jorge Lucangeli Obes <jorgelo@google.com>,
	manojgupta@google.com, llozano@google.com
Subject: Re: [PATCH] Deny preload of files on NOEXEC mounts
Date: Mon, 23 Aug 2021 12:13:09 -0700	[thread overview]
Message-ID: <CAB_TaDU0ZzoW7t_MpKo-YW43RFTCPA0RMiELfS-r+gOrUGdBsg@mail.gmail.com> (raw)
In-Reply-To: <87o89opff0.fsf@oldenburg.str.redhat.com>

Hi Florian,

> There have been public discussions about such bugs before, not sure why
> you are restricting it.

I apologise. We can add any interested individuals to view the bug
thread (including you! Just let me know). However it's not in my
ability to make that thread public. Our security team originally
wished access to it to be restricted, and I'm obligated to abide by
that. I assume it's restricted because it has an example program which
bypasses noexec on ChromeOS devices, and Google doesn't want to risk
anything. I _can_ forward a request along to make it public, but I'm
afraid it's not my decision or in my power to do so.

> I expect that it will always be possible to take over the dynamic loader
> until we are more restrictive when it comes to use of MAP_FIXED in the
> loader, probably by using MAP_FIXED_NOREPLACE.  The challenge is to make
> the change so conservative that existing (slightly broken, or ia64)
> binaries are not impacted.

Given this, what are our options on getting dynamic loader attack
preventions upstream? For example, we don't have ia64 testing
ourselves, so we can't verify no impact even if we attempted to patch
the loader on our side.

We'd obviously like to have a more permanent upstream fix. O_NEEDEXEC
/ O_MAYEXEC seems like a fine long term solution in the kernel, and
we're trying to weigh the benefits of that versus maintaining this
glibc noexec patch locally. We don't know how long that would take
however, and our toolchain team certainly doesn't have the needed
expertise or cycles at this time. Plus we'd still also need an interim
solution while that is being worked on.

Thanks,
Jordan

  reply	other threads:[~2021-08-23 19:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 19:33 [PATCH] Deny preload of files on NOEXEC mounts Jordan R Abrahams via Libc-alpha
2021-07-23 18:38 ` Adhemerval Zanella via Libc-alpha
2021-07-23 19:22   ` Florian Weimer via Libc-alpha
2021-07-23 20:42     ` Adhemerval Zanella via Libc-alpha
2021-07-23 20:50       ` Florian Weimer via Libc-alpha
2021-07-23 21:17         ` Adhemerval Zanella via Libc-alpha
2021-07-23 21:27           ` Alexander Monakov via Libc-alpha
2021-07-23 22:14             ` Jordan Abrahams via Libc-alpha
2021-08-23 11:29               ` Florian Weimer via Libc-alpha
2021-08-23 19:13                 ` Jordan Abrahams via Libc-alpha [this message]
2021-08-23 21:09                 ` Jann Horn via Libc-alpha
2021-09-06 15:10                   ` Florian Weimer via Libc-alpha
2021-09-06 21:48                     ` Mike Frysinger via Libc-alpha
2021-08-23 23:40                 ` Cristian Rodríguez
2021-08-24 12:00                   ` Adhemerval Zanella via Libc-alpha
2021-07-23 23:59             ` Adhemerval Zanella via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAB_TaDU0ZzoW7t_MpKo-YW43RFTCPA0RMiELfS-r+gOrUGdBsg@mail.gmail.com \
    --to=libc-alpha@sourceware.org \
    --cc=ajordanr@google.com \
    --cc=fweimer@redhat.com \
    --cc=jannh@google.com \
    --cc=jorgelo@google.com \
    --cc=llozano@google.com \
    --cc=manojgupta@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).