From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B50AA1F8C6 for ; Mon, 2 Aug 2021 02:35:01 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7E4C2383A826 for ; Mon, 2 Aug 2021 02:35:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E4C2383A826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627871700; bh=z9srMfr+NumgIZ2EaECogT65M3WUwRLK19qIGeTm11Q=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CCl0d1isaCjFgWc475tj68BWI34daVJGVR9kvrzPrjQ1c5Vwdoz4NRoPAQbnznJSr 3GxPypn+BM1r5Fo2ylaVDjlO6E0YayIXC9kgwEwvlNXBp57YBbT7ui7wz9gyfsFial 5vaWlve/BZBLO10kKUFGSNNveG8W1ixr/l3Xcpc8= Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id D414D3854833 for ; Mon, 2 Aug 2021 02:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D414D3854833 Received: by mail-lf1-x133.google.com with SMTP id u3so30964362lff.9 for ; Sun, 01 Aug 2021 19:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W8b8hZqqsAOC6bTFoQEo5L9d/IwMg2HjOoGwCYpuwnM=; b=gCSfWaqfaxJak6YTCgZfs4xER7CSp9uADrPLDgti5rJ0mbgxbGRVgbBfvXsjtdOCIC tfY8oceGRuHtmhP05kIHNmVwDqWHrZ5A4lMs1ArMk99iDWwi1ZMHhMdarO0I55VBw65D gk8Y9tWY6ofeYwXpAcplFtMGQhltwCbQWwqrz1D3WvJrsGs1l5hkhJcXVssKxSJ9Nw03 0cvGTxgx/S16hHWexlFhqTzY1x5e3//yLn3OT9K6Ht8Fo788untJk4038gdob7IA8Q8W 2SsKueAMe5clxuvtxdgnujNiZYT1w6OVKszrhNGOzx0l5o6HWd6ongUbjguzv8sn/phV ICWQ== X-Gm-Message-State: AOAM531nNmrHm5GnqXzMh941ioaN+brnlvC1EWlrkmIe92g6HAGP4W2y fie0waFcYDu1VJuLSewBpWOcK1lXrCVBq+m/5CkHSetSzrs= X-Google-Smtp-Source: ABdhPJwA6ubS7GN/UV021d++662bH/e+UBMH3D0k4zJvXiy8L6g95JKbsTzfUOU3ktoGsUsRdOzyfuThs60oklpX6+4= X-Received: by 2002:a05:6512:1584:: with SMTP id bp4mr3665561lfb.504.1627871674749; Sun, 01 Aug 2021 19:34:34 -0700 (PDT) MIME-Version: 1.0 References: <20210706102132.2170854-1-sidereal@google.com> In-Reply-To: Date: Mon, 2 Aug 2021 12:34:22 +1000 Message-ID: Subject: Re: [PATCH v4] rtld: Add --no-default-paths option To: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Fergus Dall via Libc-alpha Reply-To: Fergus Dall Cc: fweimer@redhat.com, chromeos-toolchain@google.com, clumptini@google.com, joseph@codesourcery.com Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Ping On Wed, Jul 28, 2021 at 4:12 PM Fergus Dall wrote: > Ping! > > Still looking for a review > > On Mon, Jul 19, 2021 at 6:34 PM Fergus Dall wrote: > >> Ping! >> >> I haven't gotten a response for this yet. >> >> Have I adequately made the case that this feature should exist? All the >> comments on previous iterations of this patchset focused on relatively >> minor details and I'm not sure if I should take that positively or not. >> >> On Tue, Jul 6, 2021 at 8:21 PM Fergus Dall wrote: >> >>> Changes from previous patchset: >>> - Incorporated vapier's suggestions. >>> - Initialized the path buffers in the tests, as strcat-ing into an >>> uninitialized buffer is undefined behavior. >>> - Stop adding support_install_prefix in tst-no-default-paths-dlopen >>> when constructing the path to the system lib directory. This >>> happened to work because I tested with prefix=/, but is in general >>> unnecessary and incorrect. >>> >>> >>>