From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 178791F5AE for ; Mon, 19 Jul 2021 08:34:34 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A3DB1393D03F for ; Mon, 19 Jul 2021 08:34:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3DB1393D03F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626683672; bh=vZIoPi63faub+Ysp5qq+mzJ2B6HFvBNMHQ9diZV3/dk=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Yt0yl3nWDJ46WW60VnOj8J8AioHIXkM+DLgB9uNSf2ZBLjb3I7ekIKNG+yeol92oN svGW0NtrtixUwRD65rYpQnR8E2uhe3QSHx7TQvV78sCCgcYJR0iG/4c7l9NRRbOc97 rHsT3MWZ0oqP81Ph94DkmpgGOP0R1ZMqpBGDAKLc= Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id 9BD193858038 for ; Mon, 19 Jul 2021 08:34:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9BD193858038 Received: by mail-io1-xd33.google.com with SMTP id w22so10895984ioc.6 for ; Mon, 19 Jul 2021 01:34:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=He677A0D213Fg7FvfCoc6bv5y2oO2e7oahSs3sKpqeE=; b=XLR90c0I5HZ9bqRbJyCjJj99DG8Ip/qtDB1RRNjaHOISo7kosympwGlDiNzWH+pqhs mM4KA9KhLJ/7UjM+ltufo0WzEor+LFdeYT0Uds9dW+qPlg3v/grwEP88kO2YRRj7yhmW Dfm5pyq8EflH1FU3mLgb5IhvLHNGqJA/H6wQwa1sg4eFVXdSEMU+4g6+yNHFLaPtoDeE tfFarXcND9SJnttyce9u8rT/M+NN4W2MNxlCW32IsHWmSK28OgFNWQ9Xd54ZBL42Vx2w A/9s8LR63GZzkRJsiLRvWGrU/ecnz6Lge/2WoJePSXP6BP1VGLBo+PBLQrudH7z2Fg7a yeyw== X-Gm-Message-State: AOAM530il79ajkDV4hZXhIjeQX6FLVvK33mCL8Bl3P69HoTdmjja4G9L 6zD+Z69Sc/8oObfFweXzRs90XylnENOgQ/tKvJulgXapHeE1cQ== X-Google-Smtp-Source: ABdhPJzZ028COFcwEYqDqFulSd/t1FJ1ZUVWY3tgxhlxLTt1WVh+lmQ1LcsH/0u0/i0gKQ2ae5/yzhHvLJHK1joJB40= X-Received: by 2002:a05:6638:c4a:: with SMTP id g10mr20698783jal.21.1626683651809; Mon, 19 Jul 2021 01:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20210706102132.2170854-1-sidereal@google.com> In-Reply-To: <20210706102132.2170854-1-sidereal@google.com> Date: Mon, 19 Jul 2021 18:34:00 +1000 Message-ID: Subject: Re: [PATCH v4] rtld: Add --no-default-paths option To: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Fergus Dall via Libc-alpha Reply-To: Fergus Dall Cc: fweimer@redhat.com, chromeos-toolchain@google.com, clumptini@google.com, joseph@codesourcery.com Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Ping! I haven't gotten a response for this yet. Have I adequately made the case that this feature should exist? All the comments on previous iterations of this patchset focused on relatively minor details and I'm not sure if I should take that positively or not. On Tue, Jul 6, 2021 at 8:21 PM Fergus Dall wrote: > Changes from previous patchset: > - Incorporated vapier's suggestions. > - Initialized the path buffers in the tests, as strcat-ing into an > uninitialized buffer is undefined behavior. > - Stop adding support_install_prefix in tst-no-default-paths-dlopen > when constructing the path to the system lib directory. This > happened to work because I tested with prefix=/, but is in general > unnecessary and incorrect. > > >