From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7E9611F44D for ; Thu, 28 Mar 2024 18:10:17 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AwjMbN0S; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A06E63858D38 for ; Thu, 28 Mar 2024 18:10:16 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CC11D385840B for ; Thu, 28 Mar 2024 18:09:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC11D385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC11D385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711649393; cv=none; b=BqQrjE3dN9QmhX10fw18sDoZdYgRDSVmm541A6EKD+4cf19Z6KEMVY/y4fu7o6LMp5FWwymGPN6LDaL66fanuKIkzCDvVoy20lQZCKPNE2RJoyOSFke3Ng7JSkByFV4gM+W7JOcoiaxr5znjD9luS8QdLmePorUfqJO3phkwn6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711649393; c=relaxed/simple; bh=YquUfnStxNaUdxO8RcgEC+NT09ePx/9h0iTXabbXnBE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=qi3zbJ5QSoAHwf+mEzaxiyPBGdU2ii5sf2gIQ3t1VhpaQ3MRbAvoipb6NeKU9KBFL7RqO0vFZiaDpHaHOw0McSkVt+iA2FpYH39khdK1+GXcq4CnBDCQkUOrKJbJkC3N00PffZo4r1D3WAjxzbNAsnZ8p6JZZuVO1p443EwKxoc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711649391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HfqCc/Si6t0EpZk3Zv3aYnVTY/OpCJte8pJMH6/gGIM=; b=AwjMbN0SWo8iiaTWgXxZFomaoq0kCusjbnDe31iS2RGIqH/4oGV4/hFkBKR7cLViHQ433q oiJzWzwRI0GmqO86l5gKVNJmdWZsDeamuEuwKZYn5yiC8ycN5xJGJAAP6ApMrvTFP8XrbY WZMe3ZyZjUrhS80c6901x/ZdJNKU75c= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-K4iMusAOM5WV99DM04Vrtw-1; Thu, 28 Mar 2024 14:09:49 -0400 X-MC-Unique: K4iMusAOM5WV99DM04Vrtw-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-29df9eab3d4so1074601a91.0 for ; Thu, 28 Mar 2024 11:09:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711649389; x=1712254189; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HfqCc/Si6t0EpZk3Zv3aYnVTY/OpCJte8pJMH6/gGIM=; b=Ofkk5gUbAFi4SRHuNj09DehUWuNa2G/zOlTkK/S2p49VhYXAe5e8rbxrDTBHsjd0nJ 6CUTvK5VVxGZAh9itcXrg9r0ImxAoquPr8lfczf90uy1kyEhiHAEa6VaVPuBxp1c54fR xDQjR8p7XTwQjjpCSBxctyFTpqCDheczylqy35cWsNZiaf96W1ckD9yrLmikASQErE6F 5sqMOIB0PHNyImq42GxWO2CpnJnmqueHsH5wNGymyyrYMTvU7MacDaGw2/pb8f/bx7yi QKyJWhoVeQB7rIlWaBgFUElg2MKKpNyuWK6hNs3WOPUCb12YxItFSSxI2fLNiebQNmXX T32w== X-Gm-Message-State: AOJu0YyOo8ksTBtW3wUcoczQGvli8sMR146JKb6c3v+zW5EfSudFuD3N PLSTmklBtRPvFwYK4Uwn7kX5jZGBXwRnQnSU4lJHtPzLqHl28pjkNbtM3J4ZH/dzrx3Z/WhomzP GWCozaSIq8kpiB3gbEVAhJMYQodA6dDdAvrmUV3y1loa9ijKKpgIhiTfcJQazdirTTiya/klY3S BgaMMKeuIYVX+FIrZHqdiIQJkePm5i+smh X-Received: by 2002:a17:903:234a:b0:1e2:15aa:1ea0 with SMTP id c10-20020a170903234a00b001e215aa1ea0mr174070plh.66.1711649388909; Thu, 28 Mar 2024 11:09:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEba5dkC8ifDJThBI+YXfRlukT6PXshnLUin2a1CVV/jx4aS+qvO7svy7O0Kql+1TsRMfDoNEhV/rfQM5DnM6Y= X-Received: by 2002:a17:903:234a:b0:1e2:15aa:1ea0 with SMTP id c10-20020a170903234a00b001e215aa1ea0mr174049plh.66.1711649388512; Thu, 28 Mar 2024 11:09:48 -0700 (PDT) MIME-Version: 1.0 References: <20240328150911.2391597-1-josimmon@redhat.com> In-Reply-To: From: Joe Simmons-Talbott Date: Thu, 28 Mar 2024 14:09:32 -0400 Message-ID: Subject: Re: [PATCH v12] posix: Deprecate group_member for Linux To: Andreas Schwab Cc: libc-alpha@sourceware.org, Florian Weimer , Paul Eggert X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On Thu, Mar 28, 2024 at 11:36=E2=80=AFAM Andreas Schwab wr= ote: > > On M=C3=A4r 28 2024, Joe Simmons-Talbott wrote: > > > diff --git a/sysdeps/posix/euidaccess.c b/sysdeps/posix/euidaccess.c > > index 4c5c2220bd..0c19021a30 100644 > > --- a/sysdeps/posix/euidaccess.c > > +++ b/sysdeps/posix/euidaccess.c > > @@ -81,7 +81,7 @@ extern int errno; > > > > #ifdef _LIBC > > > > -# define group_member __group_member > > +# define group_member __group_member2 > > # define euidaccess __euidaccess > > > > #else > > @@ -167,9 +167,14 @@ euidaccess (const char *path, int mode) > > || (stats.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH)))) > > return 0; > > > > + int gm =3D group_member (stats.st_gid); > > + if (euid !=3D stats.st_uid && egid !=3D stats.st_gid) > > + if (gm =3D=3D -1) > > + return -1; > > + > > I think this should only call group_member if needed, ie if neither euid > nor egid match. In the _LIBC case, this could return spurious errors, > otherwise. > > Also, gm should be named something like is_group_member. > Thanks for the review. I've posted a v13 patch [1] with the changes you suggested and updated faccessat to use a more descriptive temporary variable name. Thanks, Joe [1] https://sourceware.org/pipermail/libc-alpha/2024-March/155671.html > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D= 7 > "And now for something completely different." > --=20 Joe Simmons-Talbott