From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, MISSING_HEADERS,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B47941F8C6 for ; Sat, 28 Aug 2021 00:28:36 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 97FD63857C7E for ; Sat, 28 Aug 2021 00:28:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 97FD63857C7E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630110515; bh=6Yn1PtmeS7JFCSWgiad2BmJ1LGXKNO2+VA1ne+CmH/8=; h=References:In-Reply-To:Date:Subject:Cc:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wlcJD0XJA6nptZ9chY3UDU6WY9QToxmQ1iSWo74XnLxVwiPwqMEFSbh08lEbSE1aD E+psSJDCx/DbYmYMLKC5aUXBo7LrCs9f8VIpzr+aOIl6ODhnLxCrAXoG4TbNfwDd5V 91MWSKMW6W7rjPxJCL2BpQpSDDjZtogMuTw6RAb4= Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by sourceware.org (Postfix) with ESMTPS id D024B3858435 for ; Sat, 28 Aug 2021 00:28:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D024B3858435 Received: by mail-vk1-xa32.google.com with SMTP id g18so2433609vkq.8 for ; Fri, 27 Aug 2021 17:28:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=6Yn1PtmeS7JFCSWgiad2BmJ1LGXKNO2+VA1ne+CmH/8=; b=HcMcrbNv8bwZCTBIKWRI66PtaiFg+JtYwudpJselH0cRxJtoW7Xyq/tZkae3BcQfsF Jbi7Uucbmn+plyDaupceBREMBwWRhI7FobJfynu92+hXFWgBxwgVU7W+CwLWib8rbuv5 M9zaBRk3J1bMMhK7v4H4PjKEls9bObgKj2kwpApEV+K52F/v3iaBIrBlt6i6cO2p0WRc Ck4ayIKvPW3mLmPFUzVWOly9k0A3mE6irME9tFzd+hXEVdTllQFA/1TCcj+NRikucXVn pV4v0uSpGpwIcNT6IefUQPb9oV/KtT8UaLKKm636aoMSsgK+oCPHUvwxw5+suJ8dng3W vXDw== X-Gm-Message-State: AOAM5330xtemVqXH2DvkIomQU7wBixz7nx6GTcLw70m1ha4NE0l4KUkM vMhqcevK2rsrWQsaGa/givanh3lKjLgDAjqQl7Q9PPE21mjYqg== X-Google-Smtp-Source: ABdhPJyWmeShPgOZe469Q6rVF/7CjEJtOtCatHk1i5lPBMfmDueqk778bn0qwEoOqim6UlH5xyHL3W4ZXt9kv8eXe04= X-Received: by 2002:a1f:5a06:: with SMTP id o6mr3929392vkb.16.1630110490679; Fri, 27 Aug 2021 17:28:10 -0700 (PDT) MIME-Version: 1.0 References: <20210726120055.1089971-1-hjl.tools@gmail.com> In-Reply-To: <20210726120055.1089971-1-hjl.tools@gmail.com> Date: Sat, 28 Aug 2021 03:27:59 +0300 Message-ID: Subject: Re: [PATCH] x86-64: Add Avoid_Short_Distance_REP_MOVSB Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexey Tourbin via Libc-alpha Reply-To: Alexey Tourbin Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Mon, Jul 26, 2021 at 3:03 PM H.J. Lu via Libc-alpha wrote: > --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > @@ -325,12 +325,16 @@ L(movsb): > /* Avoid slow backward REP MOVSB. */ > jb L(more_8x_vec_backward) > # if AVOID_SHORT_DISTANCE_REP_MOVSB > + andl $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) > + jz 3f > movq %rdi, %rcx > subq %rsi, %rcx > jmp 2f > # endif > 1: > # if AVOID_SHORT_DISTANCE_REP_MOVSB > + andl $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) > + jz 3f > movq %rsi, %rcx > subq %rdi, %rcx > 2: Why "andl" rather than "testl"?