unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Cui, Lili via Libc-alpha" <libc-alpha@sourceware.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>,
	"H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: RE: [PATCH v4 2/2] x86_64: roundeven with sse4.1 support
Date: Mon, 1 Jun 2020 01:28:14 +0000	[thread overview]
Message-ID: <BYAPR11MB264851F0DBC8039FBC798D7A9E8A0@BYAPR11MB2648.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMe9rOr6psuzwx-uNvzUwvf2C2qi1WkfRru+wL18way598psRA@mail.gmail.com>



From: H.J. Lu <hjl.tools@gmail.com>
Sent: Friday, May 29, 2020 7:30 PM
To: Cui, Lili <lili.cui@intel.com>
Cc: Florian Weimer <fweimer@redhat.com>; H.J. Lu via Libc-alpha <libc-alpha@sourceware.org>; Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
Subject: Re: [PATCH v4 2/2] x86_64: roundeven with sse4.1 support

On Fri, May 29, 2020 at 1:48 AM Cui, Lili <lili.cui@intel.com<mailto:lili.cui@intel.com>> wrote:


> -----Original Message-----
> From: H.J. Lu <hjl.tools@gmail.com<mailto:hjl.tools@gmail.com>>
> Sent: Thursday, May 28, 2020 8:32 PM
> To: Florian Weimer <fweimer@redhat.com<mailto:fweimer@redhat.com>>; Cui, Lili <lili.cui@intel.com<mailto:lili.cui@intel.com>>
> Cc: H.J. Lu via Libc-alpha <libc-alpha@sourceware.org<mailto:libc-alpha@sourceware.org>>; Shen-Ta Hsieh
> <ibmibmibm.tw@gmail.com<mailto:ibmibmibm.tw@gmail.com>>
> Subject: Re: [PATCH v4 2/2] x86_64: roundeven with sse4.1 support
>
> On Thu, May 28, 2020 at 5:22 AM Florian Weimer <fweimer@redhat.com<mailto:fweimer@redhat.com>>
> wrote:
> >
> > * H. J. Lu via Libc-alpha:
> >
> > >> Here is a benchmark result on my AMD Ryzen 9 3900X system:
> > >
> > > Since we don't know or may not care SSE4 machines without AVX,
> > > should we make it to AVX only?
> >
> > What about Goldmont/Tremont?  Those are current CPUs which do not
> > support AVX, but I think they have sufficient SSE4 support levels for
> > this change.
> >
>
> Good point.  Lili, please collect glibc micro benchmark roundeven/roundevenf
> data before and after:
>
> https://sourceware.org/pipermail/libc-alpha/2020-May/113533.html
>
> on Tremont.
>
> --
> H.J.

Hi H.J,

Result is here.
benchmark result before this commit on Tremont



benchmark result after this commit on Tremont




Hi Lili,

The results are empty.

--
H.J.

Hi H.J,

Sorry for that my format has some problems, data is here.

benchmark result before this commit on Tremont


   "roundeven":                                        "roundevenf":

    "duration": 2.19422e+09,                    "duration": 2.19402e+09,

    "iterations": 1.44514e+08,                  "iterations": 1.4184e+08,

    "max": 43.258,                                       "max": 53.07,

    "min": 11.052,                                        "min": 12.052,

    "mean": 15.1835                                    "mean": 15.4683

benchmark result after this commit on Tremont


     "roundeven":                                   "roundevenf":

     "duration": 2.19144e+09,             "duration": 2.19218e+09,

     "iterations": 2.17075e+08,           "iterations": 1.97982e+08,

     "max": 395.428,                             "max": 34.928,

     "min": 10.044,                                "min": 11.02,

     "mean": 10.0953                           "mean": 11.0726



Thanks,

Lili.


  reply	other threads:[~2020-06-01  1:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 17:23 [PATCH] Add benchtests for roundeven and roundevenf Shen-Ta Hsieh
2020-03-27 23:25 ` Joseph Myers
2020-05-02 15:02   ` [PATCH v4 1/2] math: redirect roundeven function Shen-Ta Hsieh via Libc-alpha
2020-05-02 15:02   ` [PATCH v4 2/2] x86_64: roundeven with sse4.1 support Shen-Ta Hsieh via Libc-alpha
2020-05-28 12:05     ` H.J. Lu via Libc-alpha
2020-05-28 12:22       ` Florian Weimer via Libc-alpha
2020-05-28 12:31         ` H.J. Lu via Libc-alpha
2020-05-29  8:48           ` Cui, Lili via Libc-alpha
2020-05-29 11:29             ` H.J. Lu via Libc-alpha
2020-06-01  1:28               ` Cui, Lili via Libc-alpha [this message]
2020-06-01  2:04                 ` H.J. Lu via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB264851F0DBC8039FBC798D7A9E8A0@BYAPR11MB2648.namprd11.prod.outlook.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=ibmibmibm.tw@gmail.com \
    --cc=lili.cui@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).