From: Vladimir Isaev via Libc-alpha <libc-alpha@sourceware.org>
To: Andreas Schwab <schwab@linux-m68k.org>,
Vladimir Isaev via Libc-alpha <libc-alpha@sourceware.org>
Cc: Cupertino Miranda <Cupertino.Miranda@synopsys.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: RE: [PATCH] elf: _dl_fixup*: make @reloc_arg 64-bit safe
Date: Thu, 22 Jul 2021 13:58:53 +0000 [thread overview]
Message-ID: <BY5PR12MB4131E40A7C1EB2F154F36A30DFE49@BY5PR12MB4131.namprd12.prod.outlook.com> (raw)
In-Reply-To: <874kcmzcur.fsf@igel.home>
On Jul 22 2021, Andreas Schwab wrote:
>
> On Jul 22 2021, Vladimir Isaev via Libc-alpha wrote:
>
> > diff --git a/elf/dl-runtime.c b/elf/dl-runtime.c
> > index 9d0d941000..6099a44ffb 100644
> > --- a/elf/dl-runtime.c
> > +++ b/elf/dl-runtime.c
> > @@ -56,7 +56,7 @@ _dl_fixup (
> > # ifdef ELF_MACHINE_RUNTIME_FIXUP_ARGS
> > ELF_MACHINE_RUNTIME_FIXUP_ARGS,
> > # endif
> > - struct link_map *l, ElfW(Word) reloc_arg)
> > + struct link_map *l, uintptr_t reloc_arg)
>
> ElfW(Addr)?
>
We can use it, but I think that uintptr_t is more natural here because it is used
in reloc_offset and reloc_index.
Thank you,
Vladimir Isaev
next prev parent reply other threads:[~2021-07-22 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 13:22 [PATCH] elf: _dl_fixup*: make @reloc_arg 64-bit safe Vladimir Isaev via Libc-alpha
2021-07-22 13:39 ` Andreas Schwab
2021-07-22 13:58 ` Vladimir Isaev via Libc-alpha [this message]
2021-08-02 23:18 ` Vineet Gupta via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB4131E40A7C1EB2F154F36A30DFE49@BY5PR12MB4131.namprd12.prod.outlook.com \
--to=libc-alpha@sourceware.org \
--cc=Cupertino.Miranda@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=Vladimir.Isaev@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).