From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 811971F461 for ; Fri, 6 Sep 2019 03:21:11 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=ngHyKh8L80kX3tWe JJ0jyVe3UjD6w0bRnAQlm92ysID6sh0zZ3hAQ/6CFXI7k6KNgL3rwyGRI2gxAePq U6Pjhlk55mLvmyFYT2S4ZGKmFxnv7QOyB9s37PkdZUT9QvKAn0sbFYaB7uVE3kMH bEj/vim77eXHL8Kn9Xr7s/K5WgA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=DNSD0axqLAbwr1e1QNlM+M Ir9yw=; b=PAm9Yn6yzDx3s5Qbl7+MJw1+cSpXOgWCMS4eCEOwv2aZ4YVyJqyztO FNBLfxYg+buPl4czTCduQyNsnAsGGz1a0dx/EfSWs0kUjr58Yanb5MAy9AZYjrbd bgh+SX5qTBAAMMV+Tn0LBy3VI3NSk42dsxjwX7SG3hPY47euvlJhM= Received: (qmail 60144 invoked by alias); 6 Sep 2019 03:21:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 60135 invoked by uid 89); 6 Sep 2019 03:21:07 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com Subject: Re: [PATCH] Add UNSUPPORTED check in elf/tst-pldd. To: Adhemerval Zanella , Stefan Liebler , Florian Weimer Cc: libc-alpha@sourceware.org References: <877e6yiqsn.fsf@oldenburg2.str.redhat.com> <3b9cb5e4-7c9a-c9a4-449e-43ba98a6ad01@linaro.org> <32961942-e67b-c356-a92d-b6e45c8aaf9d@linux.ibm.com> <87blw9fxrp.fsf@oldenburg2.str.redhat.com> <1d419974-c973-c4c1-f1cd-4bbbf8b074f8@linux.ibm.com> <87tva08ijw.fsf@oldenburg2.str.redhat.com> <158c26d5-a6cc-37a9-2b23-dc8a45f52217@linux.ibm.com> From: Carlos O'Donell Message-ID: <9d86812d-9c09-df59-5191-5520762df4df@redhat.com> Date: Thu, 5 Sep 2019 23:21:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 9/3/19 9:34 AM, Adhemerval Zanella wrote: > Yes, my initial suggestion was just to make it as UNSUPPORTED for > ptrace_scope >= 1. But I do not oppose adjusting it to run on > ptrace_scope 1, it is just that the required hackery lead to make it > somewhat as complex than the test itself. The flip side of the coin is that the more "UNSUPPORTED" results we add *implies* there is "one valid way" to setup a glibc test run and we don't clearly document how to turn all the "UNSUPPORTED" entries into supported tests? Stefan's code can at least be refactored into support/ if we need to do the same thing again in another test. -- Cheers, Carlos.