From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
To: YunQiang Su <syq@debian.org>
Cc: libc-alpha@sourceware.org, Xi Ruoyao <xry111@mengyan1223.wang>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] MIPS: Setup errno for {f,l,}xstat
Date: Tue, 7 Sep 2021 11:04:07 -0300 [thread overview]
Message-ID: <97f9be81-c182-d1f3-29eb-5616831c3cfa@linaro.org> (raw)
In-Reply-To: <CAKcpw6Uuw7+sF2agtU_uaDnc-6jD+aEp5E8tdKE0OqnzX6NHeQ@mail.gmail.com>
On 07/09/2021 10:20, YunQiang Su wrote:
>
>
> Adhemerval Zanella <adhemerval.zanella@linaro.org <mailto:adhemerval.zanella@linaro.org>> 于 2021年9月7日周二 下午9:15写道:
>
>
>
> On 07/09/2021 02:31, Jiaxun Yang wrote:
> > {f,l,}xstat stub for MIPS is using INTERNAL_SYSCALL
> > to do xstat syscall for glibc ver, However it leaves
> > errno untouched and thus giving bad errno output.
> >
> > Setup errno properly when syscall returns non-zero.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com <mailto:jiaxun.yang@flygoat.com>>
>
>
> LGTM, thanks. I fixed the code style (using space instead of
> tabs as the current file is doing) and pushed upstream.
>
>
> this problem introduced in 2.33.
> is it possible to backport it to 2.33 and 2.34?
Done.
prev parent reply other threads:[~2021-09-07 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 5:31 [PATCH] MIPS: Setup errno for {f,l,}xstat Jiaxun Yang
2021-09-07 13:15 ` Adhemerval Zanella via Libc-alpha
2021-09-07 13:20 ` YunQiang Su
2021-09-07 14:04 ` Adhemerval Zanella via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97f9be81-c182-d1f3-29eb-5616831c3cfa@linaro.org \
--to=libc-alpha@sourceware.org \
--cc=adhemerval.zanella@linaro.org \
--cc=jiaxun.yang@flygoat.com \
--cc=syq@debian.org \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).