From: Xi Ruoyao via Libc-alpha <libc-alpha@sourceware.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] mips: align stack in clone [BZ #28223]
Date: Fri, 13 Aug 2021 01:27:03 +0800 [thread overview]
Message-ID: <97d59c143b34c620f5883670a21ae6286414fff6.camel@mengyan1223.wang> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2108121720120.2672396@digraph.polyomino.org.uk>
On Thu, 2021-08-12 at 17:20 +0000, Joseph Myers wrote:
> On Fri, 13 Aug 2021, Xi Ruoyao via Libc-alpha wrote:
>
> > The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and
> > N32
> > ABI require 8 byte aligned stack. Previously if the caller passed
> > an
> > unaligned stack to clone the the child misbehaved.
> >
> > Fixes bug 28223.
>
> This patch is OK.
>
I don't have git write access, waiting for a maintainer to push it.
next prev parent reply other threads:[~2021-08-12 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 16:58 [PATCH] mips: align stack in clone [BZ #28223] Xi Ruoyao via Libc-alpha
2021-08-12 17:20 ` Joseph Myers
2021-08-12 17:27 ` Xi Ruoyao via Libc-alpha [this message]
2021-08-12 20:32 ` Joseph Myers
2021-08-13 10:43 ` [PATCH] mips: increase stack alignment in clone to match the ABI Xi Ruoyao via Libc-alpha
2021-08-13 12:04 ` [PATCH v2] " Xi Ruoyao via Libc-alpha
2021-08-13 16:02 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97d59c143b34c620f5883670a21ae6286414fff6.camel@mengyan1223.wang \
--to=libc-alpha@sourceware.org \
--cc=joseph@codesourcery.com \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).