From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F3A001F8C8 for ; Wed, 22 Sep 2021 18:21:04 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F13343858031 for ; Wed, 22 Sep 2021 18:21:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F13343858031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632334863; bh=BZCBKo6buynKafM0qrNLqh4voKl5riMPAlJzBOMPQes=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kBqsISgCq+TmEUXOO55atGcdhRDRLcZttQ0k13sEOq+n+Be5kCXgrX7h0fpBBesvE R7ew0cdzTCUiS6fRnsU3HCT5C+nFVVFZa4Ny96Q3wp9MqYzVK58jkTVT9+jYO72nLd LgAcW3yNnHHMKpQjwdSg3eRbFb64AMHbRjsKSuA0= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B72353858D29 for ; Wed, 22 Sep 2021 18:20:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B72353858D29 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-A5EC-1XwO5yWHPZu6TEvQg-1; Wed, 22 Sep 2021 14:20:42 -0400 X-MC-Unique: A5EC-1XwO5yWHPZu6TEvQg-1 Received: by mail-qv1-f69.google.com with SMTP id a15-20020a0ce34f000000b0037a944f655dso14084574qvm.5 for ; Wed, 22 Sep 2021 11:20:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BZCBKo6buynKafM0qrNLqh4voKl5riMPAlJzBOMPQes=; b=JDJpdnxfoTw7BlUUUqkZWpJISwdCoXyDMBPZIPMw8X3rRuD1SPu7q2DLaupTefrfC6 Wt1lGOiZVf2r58X6z93ctz9zbij024zn31mNNfNqVo5X7RO7yHyN4+La0SVZDunuQW7v bMSaj2Z7yNOxQoGpmKveZRYnP9ogSNJRG+pZR8Sa6Nl1X466zrCYIYEEQEcEi5DsPqZR 6Az97811pMX4nfjvv7mopNfhZ/kVDyy0qJHFPYngxktMmunValJA0obeeVCY3aCrXkeR wAnjq8LDmzlA1eoHHwZKfSqTS8hvsI2JHbPqtgHIWORl6asGDo0TJ3+cPmwo+yGySrMh 1bTQ== X-Gm-Message-State: AOAM530HBVhOwgwyWAVzbnofWTrRgMfeZzPI9pfItg8mft28ng0yDl67 vHGXzIpvRECJK0KpxJeo2IL5YS+4mms2weKRCcX9+04Gz/V4ihTwTQU15iLXVGRvBiNgjnIpJjK /HupsjKyzfEkHVgRAtLAs X-Received: by 2002:a37:8c6:: with SMTP id 189mr680610qki.141.1632334840487; Wed, 22 Sep 2021 11:20:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHGJE0tCRXewcVpEfO2Lsg9qkgpFOI37IrGJ1IfHLefWPFp5OkubvH+ttkBkPBdVkIes8LJA== X-Received: by 2002:a37:8c6:: with SMTP id 189mr680456qki.141.1632334838863; Wed, 22 Sep 2021 11:20:38 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id j14sm1920550qtv.36.2021.09.22.11.20.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 11:20:38 -0700 (PDT) Message-ID: <96f589db-295c-2a1d-600f-28f9fb4b0eee@redhat.com> Date: Wed, 22 Sep 2021 14:20:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: PING^2: [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220] To: Joseph Myers References: <20210823043648.2648608-1-maskray@google.com> <87tuj255se.fsf@oldenburg.str.redhat.com> <20210904035235.giercjqdwzjukxb5@google.com> Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: Florian Weimer , Fangrui Song via Libc-alpha Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 9/22/21 14:09, Joseph Myers wrote: > On Wed, 22 Sep 2021, Carlos O'Donell via Libc-alpha wrote: > >> - Split this patch up into more logical changes. > > I'm not convinced there's much scope for splitting up this patch more; it > is a logical change (versions that changed only some architectures were a > lot uglier). My comment about logical changes was a more generic one, not > suggesting that this particular patch should be split up further. Thanks for the clarification. In which case the more detailed review of the boostrap relocations is the remaining point. -- Cheers, Carlos.