From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 01CED1F8C6 for ; Wed, 14 Jul 2021 18:50:05 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 030703857418 for ; Wed, 14 Jul 2021 18:50:05 +0000 (GMT) Received: from hamster.birch.relay.mailchannels.net (hamster.birch.relay.mailchannels.net [23.83.209.80]) by sourceware.org (Postfix) with ESMTPS id 9217B398803C for ; Wed, 14 Jul 2021 18:48:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9217B398803C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 45E9E9219FF; Wed, 14 Jul 2021 18:48:38 +0000 (UTC) Received: from pdx1-sub0-mail-a5.g.dreamhost.com (100-96-17-89.trex.outbound.svc.cluster.local [100.96.17.89]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CC795921D97; Wed, 14 Jul 2021 18:48:37 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a5.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.89 (trex/6.3.3); Wed, 14 Jul 2021 18:48:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Slimy-Harbor: 4e57a5971d0561be_1626288518103_400792451 X-MC-Loop-Signature: 1626288518103:1749156044 X-MC-Ingress-Time: 1626288518103 Received: from pdx1-sub0-mail-a5.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a5.g.dreamhost.com (Postfix) with ESMTP id 69A598AD00; Wed, 14 Jul 2021 11:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=qwLmHw iTNQ0TCkQjcBpwuzF/8nY=; b=pDy6To2NlwKLBiBiIv/a9TabRH0y1rOyHWgyIl i3V+V75BoXVyW9yUikKZRgV8gkoY4bqKWtiH76/jlcOij1ZS0vAWC0PME4B68759 eh1o/y0JMlxx+BVilxUy/fbZrgk3YCBYW5CN+zNOOJIaBFOqHIQQnMei1tw2CVPG cvORo= Received: from [192.168.1.139] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a5.g.dreamhost.com (Postfix) with ESMTPSA id 995788AC84; Wed, 14 Jul 2021 11:48:32 -0700 (PDT) Subject: Re: [PATCH v8 03/10] Remove __morecore and __default_morecore To: Adhemerval Zanella , Carlos O'Donell , Guillaume Morin References: <20210713073845.504356-1-siddhesh@sourceware.org> <20210713073845.504356-4-siddhesh@sourceware.org> <9925362a-d278-a0ad-f504-ae08ca93f628@gotplt.org> <20210714125415.GA24678@bender.morinfr.org> <45ba79b4-02e6-fae5-ae9b-db6c8a01aecb@gotplt.org> <20210714164204.GA1103@bender.morinfr.org> <63c84757-92b6-703f-b017-126518bf008b@linaro.org> X-DH-BACKEND: pdx1-sub0-mail-a5 From: Siddhesh Poyarekar Message-ID: <96a82978-c890-2ea3-7824-4f5c35adddd4@gotplt.org> Date: Thu, 15 Jul 2021 00:18:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <63c84757-92b6-703f-b017-126518bf008b@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fweimer@redhat.com, libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/14/21 11:12 PM, Adhemerval Zanella wrote: > There is some discussion last year about providing large pages support > directly on glibc without resorting to THP [1]. The idea is to hook > up the mmap/madvise with the required flags, which seems similar of > what is required by libhugetls morecore() implementation [2]. So I think > it should be feasible to add support for the required bits on glibc > and provide a tunable to actually use it. Sure, having hugetlb support within glibc is far more maintainable IMO than exposing a generic interface. > The proposed patchset does require some additional work, such as providing > is through a tunable, allowing different sizes depending of the architecture, > and maybe just dump the sbrk change in favor of just using mmap() for the > case of large pages. I think we should keep it distinct from this patchset. Since adding hugetlb support isn't likely to have an ABI impact (only tunables, which is not ABI), it could be done after 2.34. What do you think? Siddhesh