From: Florian Weimer <fweimer@redhat.com>
To: DJ Delorie <dj@redhat.com>, libc-alpha@sourceware.org
Subject: Re: RFC V2 [1/2] test-in-container
Date: Wed, 28 Feb 2018 13:56:04 +0100 [thread overview]
Message-ID: <9690b641-d241-422d-f38a-0283bea523b9@redhat.com> (raw)
In-Reply-To: <xnwoyyrx3c.fsf@greed.delorie.com>
On 02/27/2018 09:33 PM, DJ Delorie wrote:
> + while ((rsz = read (sfd, buf, 512)) > 0)
> + write (dfd, buf, rsz);
This needs error checking, and you can use copy_file_range.
Thanks,
Florian
next prev parent reply other threads:[~2018-02-28 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 20:33 RFC V2 [1/2] test-in-container DJ Delorie
2018-02-27 21:09 ` Andreas Schwab
2018-02-27 21:17 ` DJ Delorie
2018-02-28 12:49 ` Florian Weimer
2018-02-28 15:04 ` Andreas Schwab
2018-02-28 12:56 ` Florian Weimer [this message]
2018-02-28 12:57 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9690b641-d241-422d-f38a-0283bea523b9@redhat.com \
--to=fweimer@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).