[PATCH 1/2] support/timespec.h: Correct confusing comment

[PATCH 1/2] support/timespec.h: Correct confusing comment

[Mike Crowe]

I seem to have badly copied and pasted the comment describing
TEST_TIMESPEC_EQUAL_OR_AFTER in such a way that it made no sense at all.

* support/timespec.h: Correct confusing comment.
---
 ChangeLog          | 4 ++++
 support/timespec.h | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ea7b3d4f48..f870deca1a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2019-05-16  Mike Crowe  <mac@mcrowe.com>
+
+	* support/timespec.h: Correct confusing comment.
+
 2019-05-15  Mark Wielaard  <mark@klomp.org>
 
 	[BZ# 24476]
diff --git a/support/timespec.h b/support/timespec.h
index 4a8b341c5a..e9f466b3d1 100644
--- a/support/timespec.h
+++ b/support/timespec.h
@@ -62,8 +62,8 @@ void test_timespec_equal_or_after_impl (const char *file, int line,
     errno = saved_errno;                                        \
   })
 
-/* Check that the timespec on the left represents a after before the
-   time on the right. */
+/* Check that the timespec on the left represents a time equal to or
+   after the time on the right. */
 #define TEST_TIMESPEC_EQUAL_OR_AFTER(left, right)                       \
   test_timespec_equal_or_after_impl (__FILE__, __LINE__, left, right)
 
-- 
2.20.1

[PATCH 2/2] timespec: Add missing EOL terminators

[Mike Crowe]

The original implementations of test_timespec_before_impl and
test_timespec_equal_or_after in 519839965197291924895a3988804e325035beee
were missing the backslash required for a newline.

* support/timespec.c: Add backslash to correct newline in failure message.
---
 ChangeLog          | 5 +++++
 support/timespec.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f870deca1a..33925ec898 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-05-16  Mike Crowe  <mac@mcrowe.com>
+
+	* support/timespec.c: Add backslash to correct newline in failure
+	message.
+
 2019-05-16  Mike Crowe  <mac@mcrowe.com>
 
 	* support/timespec.h: Correct confusing comment.
diff --git a/support/timespec.c b/support/timespec.c
index 653293970a..7c1a4e5389 100644
--- a/support/timespec.c
+++ b/support/timespec.c
@@ -31,7 +31,7 @@ test_timespec_before_impl (const char *file, int line,
     support_record_failure ();
     const struct timespec diff = timespec_sub (left, right);
     printf ("%s:%d: %jd.%09jds not before %jd.%09jds "
-	    "(difference %jd.%09jds)n",
+	    "(difference %jd.%09jds)\n",
 	    file, line,
 	    (intmax_t) left.tv_sec, (intmax_t) left.tv_nsec,
 	    (intmax_t) right.tv_sec, (intmax_t) right.tv_nsec,
@@ -50,7 +50,7 @@ test_timespec_equal_or_after_impl (const char *file, int line,
     support_record_failure ();
     const struct timespec diff = timespec_sub (right, left);
     printf ("%s:%d: %jd.%09jds not after %jd.%09jds "
-	    "(difference %jd.%09jds)n",
+	    "(difference %jd.%09jds)\n",
 	    file, line,
 	    (intmax_t) left.tv_sec, (intmax_t) left.tv_nsec,
 	    (intmax_t) right.tv_sec, (intmax_t) right.tv_nsec,
-- 
2.20.1

Re: [PATCH 1/2] support/timespec.h: Correct confusing comment

[Adhemerval Zanella]

On 16/05/2019 09:20, Mike Crowe wrote:
> I seem to have badly copied and pasted the comment describing
> TEST_TIMESPEC_EQUAL_OR_AFTER in such a way that it made no sense at all.
> 
> * support/timespec.h: Correct confusing comment.

LTGM, I pushed for you.

> ---
>  ChangeLog          | 4 ++++
>  support/timespec.h | 4 ++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index ea7b3d4f48..f870deca1a 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2019-05-16  Mike Crowe  <mac@mcrowe.com>
> +
> +	* support/timespec.h: Correct confusing comment.
> +
>  2019-05-15  Mark Wielaard  <mark@klomp.org>
>  
>  	[BZ# 24476]
> diff --git a/support/timespec.h b/support/timespec.h
> index 4a8b341c5a..e9f466b3d1 100644
> --- a/support/timespec.h
> +++ b/support/timespec.h
> @@ -62,8 +62,8 @@ void test_timespec_equal_or_after_impl (const char *file, int line,
>      errno = saved_errno;                                        \
>    })
>  
> -/* Check that the timespec on the left represents a after before the
> -   time on the right. */
> +/* Check that the timespec on the left represents a time equal to or
> +   after the time on the right. */
>  #define TEST_TIMESPEC_EQUAL_OR_AFTER(left, right)                       \
>    test_timespec_equal_or_after_impl (__FILE__, __LINE__, left, right)
>  
> 

Re: [PATCH 2/2] timespec: Add missing EOL terminators

[Adhemerval Zanella]

On 16/05/2019 09:20, Mike Crowe wrote:
> The original implementations of test_timespec_before_impl and
> test_timespec_equal_or_after in 519839965197291924895a3988804e325035beee
> were missing the backslash required for a newline.
> 
> * support/timespec.c: Add backslash to correct newline in failure message.

LTGM, I pushed for you.

> ---
>  ChangeLog          | 5 +++++
>  support/timespec.c | 4 ++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index f870deca1a..33925ec898 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-05-16  Mike Crowe  <mac@mcrowe.com>
> +
> +	* support/timespec.c: Add backslash to correct newline in failure
> +	message.
> +
>  2019-05-16  Mike Crowe  <mac@mcrowe.com>
>  
>  	* support/timespec.h: Correct confusing comment.
> diff --git a/support/timespec.c b/support/timespec.c
> index 653293970a..7c1a4e5389 100644
> --- a/support/timespec.c
> +++ b/support/timespec.c
> @@ -31,7 +31,7 @@ test_timespec_before_impl (const char *file, int line,
>      support_record_failure ();
>      const struct timespec diff = timespec_sub (left, right);
>      printf ("%s:%d: %jd.%09jds not before %jd.%09jds "
> -	    "(difference %jd.%09jds)n",
> +	    "(difference %jd.%09jds)\n",
>  	    file, line,
>  	    (intmax_t) left.tv_sec, (intmax_t) left.tv_nsec,
>  	    (intmax_t) right.tv_sec, (intmax_t) right.tv_nsec,
> @@ -50,7 +50,7 @@ test_timespec_equal_or_after_impl (const char *file, int line,
>      support_record_failure ();
>      const struct timespec diff = timespec_sub (right, left);
>      printf ("%s:%d: %jd.%09jds not after %jd.%09jds "
> -	    "(difference %jd.%09jds)n",
> +	    "(difference %jd.%09jds)\n",
>  	    file, line,
>  	    (intmax_t) left.tv_sec, (intmax_t) left.tv_nsec,
>  	    (intmax_t) right.tv_sec, (intmax_t) right.tv_nsec,
>